Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse a single Search Editor tab per window #100048

Closed
swrobel opened this issue Jun 13, 2020 · 6 comments
Closed

Reuse a single Search Editor tab per window #100048

swrobel opened this issue Jun 13, 2020 · 6 comments
Assignees
@JacksonKearl
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders search-editor verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2020

Comments

@swrobel
Copy link

swrobel commented Jun 13, 2020

I thought I'd flag to @JacksonKearl that I'm interested in this feature as well (since I know @kolpav is), as discussed here.

I love the search editor, but due to having bound it to cmd+shift+F to replace the existing search functionality, I end up with a ton of open Search Editor tabs, when what I really want is a max of 1 that is reused for each new search. When this setting is enabled, I would imagine that it would focus that tab on invocation of search.action.OpenNewEditor (or perhaps this would just be a separate command?), and highlight all of the currently-entered text in the search box.
@JacksonKearl JacksonKearl self-assigned this Jun 13, 2020
@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label Jul 30, 2020
@JacksonKearl JacksonKearl added this to the Backlog milestone Jul 30, 2020
@JacksonKearl
Copy link
Contributor

I agree, I could see this as a new command.

@JacksonKearl JacksonKearl modified the milestones: Backlog, July 2020 Jul 30, 2020
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jul 30, 2020 •
edited

Added search.action.openEditor, also available in command pallet as "Open Search Editor" (as opposed to "New Search Editor" né "Open new Search Editor"), which will open an existing search editor if one exists, otherwise create a new one.

@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Jul 30, 2020
@isidorn isidorn added the verified Verification succeeded label Aug 5, 2020
@pstrum
Copy link

pstrum commented Aug 17, 2020

With "New Search Editor," if I have a selection it is put into the input of the new search editor. However, with "Open Search Editor" the selection does not replace what was already in the input of the existing search editor. Is this the correct behavior? Is there a setting to enable selection to auto-fill the existing search editor when I run the new search.action.openEditor command?

@JacksonKearl
Copy link
Contributor

@pstrum no setting for that, though it would make sense for a feature request.

@hesting15
Copy link

When several search editors are open, by triggering search.action.openEditor we always go to the latest window. It would be nice to cycle through search editors if we are already inside search editor.

@JacksonKearl
Copy link
Contributor

@hesting15 again no setting for that, though it would make sense for a feature request.

@swrobel swrobel mentioned this issue Aug 19, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders search-editor verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
6 participants
@swrobel @isidorn @JacksonKearl @pstrum @hesting15 and others