Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openWith.ts should move into editor service #100057

Closed
bpasero opened this issue Jun 13, 2020 · 1 comment · Fixed by #100466
Closed

openWith.ts should move into editor service #100057

bpasero opened this issue Jun 13, 2020 · 1 comment · Fixed by #100466
Assignees
@bpasero
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders workbench-editors Managing of editor widgets in workbench window
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 13, 2020

Is there any reason we have openWith.ts as separate thing in files land? This is not really files specific, or is it?

Wouldn't it make more sense that you could use the editor service to openEditorWith and have all that logic be provided from there?
@bpasero bpasero added debt Code quality issues workbench-editors Managing of editor widgets in workbench window labels Jun 13, 2020
@mjbvz mjbvz added this to the Backlog milestone Jun 15, 2020
@bpasero bpasero assigned bpasero and unassigned mjbvz Jun 18, 2020
@bpasero bpasero modified the milestones: Backlog, June 2020 Jun 18, 2020
bpasero added a commit that referenced this issue Jun 18, 2020
@bpasero
editors - move open with to editor (fix #100057)
2996057
@bpasero bpasero mentioned this issue Jun 18, 2020
Merged
@bpasero
Copy link
Member Author

bpasero commented Jun 18, 2020

I did a PR to move it into editor land but not into the service. I think this is still better because this functionality is independent from files domain.

bpasero added a commit that referenced this issue Jun 19, 2020
@bpasero
editors - move open with to editor (fix #100057) (#100466)
801ab0e
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

editors - move open with to editor (fix #100057) microsoft/vscode
3 participants
@bpasero @mjbvz and others