Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code runs stale persisted launch configs #100265

Closed
weinand opened this issue Jun 16, 2020 · 2 comments
Closed

VS Code runs stale persisted launch configs #100265

weinand opened this issue Jun 16, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded

Comments

@weinand
Copy link
Contributor

weinand commented Jun 16, 2020

VS Code 1.46

  • start VS Code Stable
  • use this launch config:
    {
       "type": "node",
       "request": "launch",
       "name": "echo args",
       "runtimeExecutable": "echo",
       "args": [ "hello", "world" ]
    },
    
  • close "launch.json" editor
  • run it
  • Observe: (everything is good)
    2020-06-16_09-34-37
  • shutdown VS Code
  • open same project with VS Code Insiders (or any other editor)
  • modify "launch.json" and include argument "1234" between "hello" and "world"
  • shutdown VS Code Insiders
  • launch VS Code Stable again
  • go to debug view and run "echo args" launch config
  • open launch.json
  • Observe:
    2020-06-16_09-39-11

VS Code runs old launch config which lacks the "1234".

Workaround: an edit change of launch.json is needed before VS Code will run the correct launch config.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority debug Debug viewlet, configurations, breakpoints, adapter issues candidate Issue identified as probable candidate for fixing in the next release labels Jun 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 16, 2020

We no longer store the configuration in storage. The only downside is that now when you select a dynamic configuration, reload, we do not preserve the dynamic configuratoin and you have to select it again. For that we would have to store the "origin" as you suggested, but that I will tackle as a seperate issue, thus reopening #96293

@weinand
Copy link
Contributor Author

weinand commented Jun 16, 2020

I've verified that no stale launch configs are run.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants