Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing character casing in file name doesn't take effect in editor #100436

Closed
elanhamburger opened this issue Jun 18, 2020 · 6 comments
Closed

Changing character casing in file name doesn't take effect in editor #100436

elanhamburger opened this issue Jun 18, 2020 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
June 2020

Comments

@elanhamburger
Copy link

Changing the capitalization of any character(s) in the name of a file in the explorer does not get reflected into the editor, even after closing and re-opening the file. For example:

  1. Create a new file in file explorer, e.g. newfile.js (Optionally close the editor that automatically opens.)
  2. Change capitalization of any part of new file name, e.g. rename to NewFile.js
  3. Open the renamed file in the editor
    Expected: The editor tab will show new name "NewFile.js"
    Actual: The editor tab shows old name "newfile.js"

Even the tooltip over the editor tab shows the old file name.

VS Code version: Code 1.46.0 (a5d1cc2, 2020-06-10T08:59:06.977Z)
OS version: Darwin x64 19.5.0
@isidorn isidorn assigned bpasero and unassigned isidorn Jun 18, 2020
@bpasero
Copy link
Member

bpasero commented Jun 18, 2020

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 18, 2020
@isidorn isidorn mentioned this issue Jun 18, 2020
Closed
@JacksonKearl JacksonKearl added the file-io File I/O label Jun 18, 2020
@elanhamburger
Copy link
Author

elanhamburger commented Jun 19, 2020 •
edited

@bpasero Slight modification for version 1.47.0-insider

Renaming the file causes the name of the file in the editor tab to change, but it does not change the name of the file in the breadcrumb underneath the tab. When you save the file, the file name in the editor tab reverts itself to the previous casing, even across multiple renames of the file.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editors Managing of editor widgets in workbench window and removed file-io File I/O info-needed Issue requires more information from poster labels Jun 19, 2020
@bpasero bpasero added this to the June 2020 milestone Jun 19, 2020
@bpasero
Copy link
Member

bpasero commented Jun 19, 2020

Yeah, my change was not complete. Adding @jrieken for breadcrumb, but I am actually not sure how to fix it there because breadcrumbs are probably just picking on the resource of the input. We might have to expose the label thing I introduced to the file inputs to others for consumption?

@jrieken
Copy link
Member

jrieken commented Jun 19, 2020

Yeah, good question. Breadcrumbs use the resource from the file input and actually not just the name but every path segment of it. So, changing the casing of a parent folder would have the same problem...

@bpasero
Copy link
Member

bpasero commented Jun 19, 2020

I wonder if the generic EditorInput should not only have resource but also label: URI so that everyone can adopt this.

@yume-chan yume-chan mentioned this issue Jun 19, 2020
Closed
@bpasero
Copy link
Member

bpasero commented Jun 20, 2020

I extracted the breadcrumbs issue into #100633

This was referenced Jun 21, 2020
Closed
Closed
@yume-chan yume-chan mentioned this issue Jun 29, 2020
Closed
@jrieken jrieken added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
6 participants
@bpasero @jrieken @isidorn @JacksonKearl @elanhamburger and others