Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening notebook from SCM view opens text editor #100468

Closed
chrmarti opened this issue Jun 18, 2020 · 4 comments
Closed

Opening notebook from SCM view opens text editor #100468

chrmarti opened this issue Jun 18, 2020 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2020

Comments

@chrmarti
Copy link
Contributor

Issue Type: Bug

  • Have a .github-issues notebook with changes.
  • Clicking on the 'Open File` inline action in the SCM View open the text editor on the file.

I'd expect to get the notebook editor, just like when opening the file from the Explorer viewlet.

VS Code version: Code - Insiders 1.47.0-insider (84f52fe, 2020-06-17T06:56:23.406Z)
OS version: Darwin x64 19.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (3.25GB free)
Process Argv -psn_0_12422104
Screen Reader no
VM 18%
Extensions (26)
Extension Author (truncated) Version
unique-lines bib 1.0.0
regex chr 0.2.0
vscode-eslint dba 2.1.5
ghlink dt 1.2.0
remotehub eam 0.5.0
tsl-problem-matcher eam 0.2.0
EditorConfig Edi 0.15.1
vscode-pull-request-github-insiders Git 2020.6.23941
rest-client hum 0.24.1
graphql-for-vscode kum 1.15.3
vscode-docker ms- 1.3.0
vscode-kubernetes-tools ms- 1.2.1
python ms- 2020.6.88468
remote-containers ms- 0.122.99
remote-ssh-edit-nightly ms- 2020.6.3953
remote-ssh-nightly ms- 2020.6.3953
remote-wsl ms- 0.44.3
azure-account ms- 0.8.11
azurecli ms- 0.5.0
js-debug-nightly ms- 2020.6.1717
vscode-github-issue-notebooks ms- 0.0.31
debugger-for-chrome msj 4.12.8
vscode-versionlens pfl 1.0.8
vscode-yaml red 0.8.0
vscode-open-in-github sys 1.14.0
vscodeintellicode Vis 1.2.8
@joaomoreno
Copy link
Member

joaomoreno commented Jun 21, 2020 •
edited

@bpasero I'm calling window.showTextDocument, as suggested before. Is this not recommended now that documents can be opened in editors other than text? What is the recommended way? vscode.open command?

vscode/extensions/git/src/commands.ts

Line 861 in 65fa899

await window.showTextDocument(document, opts);

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jun 21, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Jun 21, 2020
@bpasero
Copy link
Member

bpasero commented Jun 22, 2020

@jrieken should answer, I think he changed showTextDocument to enforce opening as text.

@jrieken
Copy link
Member

jrieken commented Jun 22, 2020

Yes - use vscode.open. The showTextDocument will show a text document and its contract is that it returns a text editor which naturally cannot be a notebook

@joaomoreno
Copy link
Member

Alrighty!

@joaomoreno joaomoreno modified the milestones: Backlog, July 2020, June 2020 Jun 24, 2020
@joaomoreno joaomoreno added the debt Code quality issues label Jul 1, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
6 participants
@joaomoreno @bpasero @jrieken @RMacfarlane @chrmarti and others