Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover service should not be contrib but core service #100637

Closed
bpasero opened this issue Jun 20, 2020 · 0 comments
Closed

Hover service should not be contrib but core service #100637

bpasero opened this issue Jun 20, 2020 · 0 comments
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders workbench-hover Hover issues in the workbench
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 20, 2020

I suggest to move the IHoverService out of contrib into a layer that is accessible by core workbench. E.g. if we wanted to use it in the tabs, that is a requirement.
@bpasero bpasero added debt Code quality issues workbench-hover Hover issues in the workbench labels Jun 20, 2020
@Tyriar Tyriar added this to the June 2020 milestone Jun 20, 2020
@Tyriar Tyriar closed this as completed in e16aead Jun 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders workbench-hover Hover issues in the workbench
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
3 participants
@bpasero @Tyriar and others