Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension controls should be next to where the extensions info is rendered in focus order #101185

Closed
Neurrone opened this issue Jun 27, 2020 · 9 comments
Closed

Extension controls should be next to where the extensions info is rendered in focus order #101185

Neurrone opened this issue Jun 27, 2020 · 9 comments
Assignees
@isidorn @mjbvz
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code
Milestone
Backlog

Comments

@Neurrone
Copy link

CC: @isidorn

Issue Type: Bug

  1. Open the info for any extension. E.g, ctrl+shift+x, and go to the first result for "Code Spell Checker".

Expected: when the problems view is open at the bottom, pressing shift+tab from the top of the virtual document which renders extension info should cause focus to move to the controls for managing the extension. E.g, the view changelog and install / uninstall extension button.

Actual: I'm forced to tab through all the controls in the problems pane first, which is about 8 tab stops before getting to where I need to be to install the extension

As an aside, pressing f6 does allow you to move focus to the virtual document where the extension's info is rendered. But f6 / shift+f6 isn't able to move focus from it, so focus is trapped there when using f6 / shift + f6 to cycle through major parts of the UI. Not sure if I should open a separate issue for this.

VS Code version: Code - Insiders 1.47.0-insider (9bf6af0, 2020-06-26T18:55:07.038Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.86GB (4.37GB free)
Process Argv
Screen Reader yes
VM 17%
Extensions (15)
Extension Author (truncated) Version
notes can 1.0.1
vscode-markdownlint Dav 0.36.1
vscode-eslint dba 2.1.5
gitlens eam 10.2.2
prettier-vscode esb 5.1.0
Go gol 0.14.4
rest-client hum 0.24.1
python ms- 2020.6.90262
remote-wsl ms- 0.44.4
cpptools ms- 0.28.3
vsnotes pat 0.7.1
rust rus 0.7.8
markdown-preview-enhanced shd 0.5.12
code-spell-checker str 1.9.0
vscode-webhint web 1.5.6
@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jun 28, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 29, 2020

@sandy081 here are two issues from the comment above

  1. Have extension descriptoin open and focused in a web view, and have the panel open. Press Shit + Tab -> focus goes to panel, it should go to the sidebar
  2. Have extension description open and focused. Press F6 -> no effect, focus is not moved across the workbench

Notice how the F6 key is registered with no precondition here so I am not sure why the extension webview is eating up the F6 and shift + F6 key.

@microsoft microsoft deleted a comment from sandy081 Jun 29, 2020
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed info-needed Issue requires more information from poster labels Jun 29, 2020
@sandy081 sandy081 added the extensions Issues concerning extensions label Nov 3, 2020
@sandy081 sandy081 added this to the November 2020 milestone Nov 3, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 3, 2020

@mjbvz Can you please let me know if there are any web view options I can use to fix this?

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Nov 9, 2020
mjbvz added a commit that referenced this issue Nov 12, 2020
@mjbvz
Fix F6 in extension page webviews
050a123 
For #101185

Make sure we set the correct parent flow to
@mjbvz
Copy link
Contributor

mjbvz commented Nov 12, 2020

@sandy081 I pushed a fix for F6.

I'm not sure about the expected shift+tab behavior. Can you please test out the next insiders build and let me know what should be happening?

meganrogge pushed a commit that referenced this issue Nov 18, 2020
@mjbvz @meganrogge
Fix F6 in extension page webviews
666ad5d 
For #101185

Make sure we set the correct parent flow to
@sandy081
Copy link
Member

sandy081 commented Nov 27, 2020 •
edited

F6 is working but shift+tab from web view editor is going to panel. It is also true when you open Markdown preview editor and do shift+tab.

Assigning to @mjbvz & @isidorn since it happens for all web view editors.

@sandy081 sandy081 removed the extensions Issues concerning extensions label Nov 27, 2020
@sandy081 sandy081 removed their assignment Nov 27, 2020
@sandy081 sandy081 removed this from the November 2020 milestone Nov 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2020

@mjbvz can we change that the shift + tab from webviews goes to sidebar and not to the panel. That is the only remaining problem here it seems?

@isidorn
Copy link
Contributor

isidorn commented Mar 2, 2021

@mjbvz friendly ping for this since I know you were fixing some webview focus issues lately

@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2021

@mjbvz friendly ping

@mjbvz
Copy link
Contributor

mjbvz commented Aug 18, 2021

I'm not sure how to fix this

@mjbvz mjbvz added this to the Backlog milestone Oct 4, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 31, 2022
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isidorn isidorn

@mjbvz mjbvz

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@isidorn @sandy081 @mjbvz @Neurrone @VSCodeTriageBot