Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Markdown links don't work on codespaces #101203

Closed
craignicol opened this issue Jun 27, 2020 · 9 comments
Closed

Internal Markdown links don't work on codespaces #101203

craignicol opened this issue Jun 27, 2020 · 9 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug github-codespaces markdown Markdown support issues verified Verification succeeded
Milestone
October 2021

Comments

@craignicol
Copy link

craignicol commented Jun 27, 2020 •
edited

When I have a markdown file referencing another markdown file, and I follow the link whilst using codespaces on the web, it opens a new window containing only the text "Not Found", rather than opening the file within VSCode as expected.

Repro steps :

  • Create a new repo
  • Add a README.md file
  • Add a CONTRIBUTION.md file
  • Add [How to contribute](CONTRIBUTION.md) to the readme
  • Preview the Readme file
  • Click the "how to contribute" link

Expected:
Contribution.MD loads in an editor window, as it does locally

Actual:
New window opens with text Not Found

Filename in example is arbitrary, any relative link fails
@gjsjohnmurray
Copy link
Contributor

Maybe #85105

@craignicol
Copy link
Author

Maybe. I've added repro steps here to compare

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Jul 9, 2020
@mjbvz mjbvz added this to the July 2020 milestone Jul 10, 2020
mjbvz added a commit that referenced this issue Jul 10, 2020
@mjbvz
Working on supporting markdown links in serverless+web
fdf23dc 
For #101203
@mjbvz mjbvz closed this as completed in 731f9c2 Jul 24, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Jul 24, 2020

Tested the fix using a local web build of VS Code. Codespaces may take a little time to pick this up

@JacksonKearl
Copy link
Contributor

image
Not sure if this is a webUI only issue. But seeing this

@JacksonKearl
Copy link
Contributor

Works with local build though.. 🤷‍♀️

@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 6, 2020
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Aug 6, 2020 •
edited

GitHub Codespaces is on insiders from 3 days ago and still seeing this there.

Version: 1.48.0-insider
Commit: 5696bab
Date: 2020-08-03T05:36:22.645Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36 Edg/84.0.522.52

image

@JacksonKearl JacksonKearl removed the verified Verification succeeded label Aug 6, 2020
@JacksonKearl JacksonKearl reopened this Aug 6, 2020
@JacksonKearl JacksonKearl added the verification-found Issue verification failed label Aug 6, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Aug 7, 2020

Thanks for testing @JacksonKearl. Yes I only tested with a local web build. Will see if I can figure out what is different about code spaces...

@mjbvz mjbvz modified the milestones: July 2020, August 2020 Aug 7, 2020
@mjbvz mjbvz removed the verification-found Issue verification failed label Aug 7, 2020
@mjbvz mjbvz modified the milestones: August 2020, September 2020 Aug 31, 2020
@mjbvz mjbvz mentioned this issue Sep 28, 2020
Closed
@mjbvz mjbvz modified the milestones: September 2020, On Deck Sep 30, 2020
@ConProgramming
Copy link

Anyone working on this? Want to use for https://foambubble.github.io/foam/graph-visualisation

@mjbvz mjbvz modified the milestones: On Deck, June 2021 May 21, 2021
@mjbvz mjbvz removed this from the June 2021 milestone Jun 30, 2021
@mjbvz mjbvz added this to the July 2021 milestone Jun 30, 2021
@mjbvz mjbvz modified the milestones: July 2021, On Deck Jul 29, 2021
mjbvz added a commit that referenced this issue Oct 14, 2021
@mjbvz
Try to clairify how md links are resolved
d1f72b5 
For #101203

The current logic ends up tossing out the uri scheme and other important info when opening md links. This PR tries to avoid that
@mjbvz mjbvz modified the milestones: On Deck, October 2021 Oct 14, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 14, 2021

/fixedBy 830987e

Should be working now (tested on VS Code docs)

@mjbvz mjbvz closed this as completed Oct 14, 2021
@roblourens roblourens added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug github-codespaces markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
7 participants
@craignicol @roblourens @gjsjohnmurray @JacksonKearl @mjbvz @ConProgramming and others