Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot save untitled notebook #101362

Closed
chrmarti opened this issue Jun 30, 2020 · 5 comments
Closed

Cannot save untitled notebook #101362

chrmarti opened this issue Jun 30, 2020 · 5 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
June 2020

Comments

@chrmarti
Copy link
Contributor

Testing #101295

  • Create Untitled notebook.
  • Enter some content.
  • Try so save:
Failed to save 'Untitled-1': Unable to resolve filesystem provider with relative file path 'untitled:Untitled-1'
onDidChangeNotification @ notificationsAlerts.ts:40
(anonymous) @ notificationsAlerts.ts:26
fire @ event.ts:587
addNotification @ notifications.ts:207
error @ notificationService.ts:59
j @ fileCommands.ts:412
processTicksAndRejections @ internal/process/task_queues.js:85
async function (async)
j @ fileCommands.ts:410
G @ fileCommands.ts:372
handler @ fileCommands.ts:422
invokeFunction @ instantiationService.ts:61
_tryExecuteCommand @ commandService.ts:84
(anonymous) @ commandService.ts:73
Promise.then (async)
executeCommand @ commandService.ts:73
_doDispatch @ abstractKeybindingService.ts:200
_dispatch @ abstractKeybindingService.ts:159
(anonymous) @ keybindingService.ts:251
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Jul 1, 2020
@rebornix rebornix added this to the June 2020 milestone Jul 1, 2020
@bpasero
Copy link
Member

bpasero commented Jul 2, 2020

I can still reproduce this following these steps:

  • new untitled file
  • reopen with "Notebook"
  • this works and I can edit
  • try to save
 ERR Unable to resolve text model content for resource vscode-notebook-cell:/Users/bpasero/Desktop/Untitled-1#0000000: Error: Unable to resolve text model content for resource vscode-notebook-cell:/Users/bpasero/Desktop/Untitled-1#0000000
    at S.resolveTextModelContent (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6045:7)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at async S.doCreateReferencedObject (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6043:841)
    at async b.createModelReference (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6045:676)
    at async resolveTextModelRef (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3252:937)
    at async c.resolveTextModel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3288:866)

@bpasero bpasero reopened this Jul 2, 2020
@bpasero bpasero added the verification-found Issue verification failed label Jul 2, 2020
@bpasero
Copy link
Member

bpasero commented Jul 2, 2020

Btw maybe we could add a "New Untitled Notebook" command.

@rebornix
Copy link
Member

rebornix commented Jul 2, 2020

I'm not seeing any error in Insiders and master by following steps:

  • CMD+N to create an untitled file
  • Reopen With Github Issue Notebook
  • Edit
  • CMD+S to save, save as test.github-issues
  • The editor is then replaced with new github notebook editor

Closing and removing verification-found to let others give it a test. Maybe @bpasero can reproduce this issue in other ways, if so we can reopen and then fix in next iteration.

@rebornix rebornix closed this as completed Jul 2, 2020
@rebornix rebornix removed the verification-found Issue verification failed label Jul 2, 2020
@bpasero
Copy link
Member

bpasero commented Jul 3, 2020

@rebornix my steps involve not setting any file extension and you get this error: Unable to open 'Untitled-1': Cannot read property 'kernel' of undefined.

Your steps work fine. I can open a new issue if you want?

@bpasero bpasero added the verified Verification succeeded label Jul 3, 2020
@rebornix
Copy link
Member

rebornix commented Jul 7, 2020

@bpasero thanks, the error should be avoided as the file extension is necessary for saving a github notebook. I created a new issue #101827 to track it.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@rebornix @bpasero @chrmarti and others