New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook: weird drop-shadow border around active cell #101375
Comments
Related to #101285 |
You could try setting |
This one is tough because the drop shadow is a common trait in other notebooks (collab, nteract, etc.) and it seems like this comes down to personal preference. We do have some themes that hide shadows altogether, and we've re-used that token here to respect that. One thing we could add is a slight border to the top and bottom of the cell like in the case where shadows are hidden: |
@misolori If in doubt I would go for a consistent design language here and not use shadows to indicate focus. We indicate focus via blue outline everywhere in the UI, so I do not understand why the shadows are used only for notebooks. Imho that is inconsistent design language we should avoid. |
@bpasero we removed the shadow for the active cell: |
Love it 👍 |
Testing #100965
I would prefer just the focus outline I think:
The text was updated successfully, but these errors were encountered: