Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: weird drop-shadow border around active cell #101375

Closed
bpasero opened this issue Jun 30, 2020 · 8 comments
Closed

Notebook: weird drop-shadow border around active cell #101375

bpasero opened this issue Jun 30, 2020 · 8 comments
Assignees
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 30, 2020

Testing #100965

I would prefer just the focus outline I think:

image

@isidorn
Copy link
Contributor

isidorn commented Jun 30, 2020

Related to #101285

@miguelsolorio
Copy link
Contributor

You could try setting notebook.focusedCellShadow to #0000 and seeing if that feels better.

@rebornix rebornix assigned roblourens and unassigned rebornix Jun 30, 2020
@bpasero
Copy link
Member Author

bpasero commented Jul 1, 2020

@misolori yes better. I really think we should not have this shadow by default, just see how bad it looks on the edge to the sidebar:

image

Can we consider this for June?

@bpasero
Copy link
Member Author

bpasero commented Jul 1, 2020

Compare with inline editors that have no shadow:

image

@rebornix rebornix added this to the June 2020 milestone Jul 1, 2020
@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues labels Jul 1, 2020
@miguelsolorio
Copy link
Contributor

This one is tough because the drop shadow is a common trait in other notebooks (collab, nteract, etc.) and it seems like this comes down to personal preference. We do have some themes that hide shadows altogether, and we've re-used that token here to respect that.

One thing we could add is a slight border to the top and bottom of the cell like in the case where shadows are hidden:

image

@bpasero
Copy link
Member Author

bpasero commented Jul 3, 2020

This one is tough because the drop shadow is a common trait in other notebooks (collab, nteract, etc.) and it seems like this comes down to personal preference

@misolori If in doubt I would go for a consistent design language here and not use shadows to indicate focus. We indicate focus via blue outline everywhere in the UI, so I do not understand why the shadows are used only for notebooks. Imho that is inconsistent design language we should avoid.

@kieferrm kieferrm modified the milestones: June 2020, July 2020 Jul 6, 2020
@miguelsolorio
Copy link
Contributor

@bpasero we removed the shadow for the active cell:

image

@bpasero
Copy link
Member Author

bpasero commented Jul 14, 2020

Love it 👍

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

6 participants