Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compacted debug sessions should show name of child and not of parent #101429

Closed
weinand opened this issue Jun 30, 2020 · 4 comments
Closed

compacted debug sessions should show name of child and not of parent #101429

weinand opened this issue Jun 30, 2020 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2020

Comments

@weinand
Copy link
Contributor

weinand commented Jun 30, 2020 •
edited

Testing #101009

When hierarchical debug sessions are compacted, the resulting tree node uses the name of the parent session, not the name of the child session.

So this uncompressed tree:
2020-06-30_18-40-53

becomes this:
2020-06-30_18-42-40

IMO this does not make sense because the compact feature eliminates the parent when there is only one child.
It does not eliminate the child.
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 30, 2020
@weinand weinand changed the title compressed debug sessions should show name of child and not of parent compacted debug sessions should show name of child and not of parent Jun 30, 2020
@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2020 •
edited

@weinand what you are saying makes sense, however for js-debug this would not really work that well scine the child sessions have "weird names".

What I suggest: we change this on the vscode side as you suggest - to use the child name
And @connor4312 improves on the JS-debug side the names of child sessions: for example to be NAME_OF_CONFIG + process ID
So something like "Launch Program 1452"

@isidorn isidorn added this to the June 2020 milestone Jul 1, 2020
@weinand
Copy link
Contributor Author

weinand commented Jul 1, 2020 •
edited

@isidorn yes, we we will have to go with your proposal.

Another argument for that approach: with the current behavior the "weird name" child gets the "nice name" from the parent. But if another child arrives, suddenly two "weird names" shows up...

An alternative approach would be that VS Code automatically concatenates the names from parent and child as you suggested. But I'm not sure how well that would work in practice...

@connor4312 what's your take on this?

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 1, 2020
@int19h
Copy link

int19h commented Jul 1, 2020 •
edited

It's not just JS. Python also has "weird" child session names - they're basically "Subprocess ...", where ... is the process ID. Concatenating them would also not work well.

I'm not sure why it's a weird scheme, though. This naming scheme works just fine when the tree is fully expanded - it tells users exactly what they need to know, without overburdening them with redundant information that's already available (e.g. repeating parent process name). It feels weird having to change that just to play well with a subset of scenarios that involve compacting.

Also, if #101140 is implemented, I don't think it would be accurate to describe compacting as eliminating the parent session anymore.

isidorn added a commit that referenced this issue Jul 2, 2020
@isidorn
change noCompress -> compress and make default to not compress sessio…
a301dc5 
…ns in call stack

#101429
@isidorn isidorn closed this as completed in 1388542 Jul 2, 2020
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jul 2, 2020
This was referenced Jul 2, 2020
Closed
Open
@isidorn
Copy link
Contributor

isidorn commented Jul 2, 2020 •
edited

After discussions with @weinand we decided to do the following changes:

  • Change the noCompact flag to be compact flag and thus the default value is to not compact sessions. So this is opt-in
  • Changed call stack to display the name of the Child Session. I actually think by default it does not looks so "weird"

@connor4312 As a follow up for js-debug I have created this item microsoft/vscode-js-debug#551
@int19h as a follow up for python I have created microsoft/vscode-python-debugger#166

Screenshot 2020-07-02 at 11 45 13

@isidorn isidorn mentioned this issue Jul 2, 2020
Closed
@connor4312 connor4312 added the verified Verification succeeded label Jul 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
5 participants
@int19h @weinand @isidorn @connor4312 and others