Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show twistie for a childless compressed node #101431

Closed
weinand opened this issue Jun 30, 2020 · 2 comments
Closed

do not show twistie for a childless compressed node #101431

weinand opened this issue Jun 30, 2020 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2020

Comments

@weinand
Copy link
Contributor

weinand commented Jun 30, 2020

Testing #101009

An uncompressed debug session tree shows twisties only where it makes sense:
2020-06-30_18-40-53

The corresponding compressed tree shows a twistie despite the fact that it is really the "leaf" from the uncompressed tree:
2020-06-30_18-42-40
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 30, 2020
@weinand weinand changed the title do not show twistie for compressed nodes do not show twistie for a childless compressed node Jun 30, 2020
@connor4312
Copy link
Member

I was about to open an issue for this. I can reproduce this by having a parent session that spawns and unspawns a child, specifically running this script via launch config or the debug terminal: https://github.com/microsoft/vscode-js-debug/blob/master/demos/node/parent.js

@isidorn isidorn added this to the June 2020 milestone Jul 1, 2020
@isidorn isidorn closed this as completed in b15f21b Jul 1, 2020
@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2020

Well I automatically expand all parent sessions so the compressed state would be immediatly visible..
I also introduced a check to not auto expand the same session twice so that user can explicitlyt collapse something.
I just change the logic now that we allow to auto collapse a session if it has a new child element - what seem to be the case here.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2020
@isidorn isidorn mentioned this issue Jul 1, 2020
Closed
@connor4312 connor4312 added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@weinand @isidorn @connor4312 and others