Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimelineItem accessibilityInformation#role not working #101442

Closed
JacksonKearl opened this issue Jun 30, 2020 · 2 comments
Closed

TimelineItem accessibilityInformation#role not working #101442

JacksonKearl opened this issue Jun 30, 2020 · 2 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2020

Comments

@JacksonKearl
Copy link
Contributor

Testing #100936

I don't see anything related to roles in the voiceover, and inspecting the DOM it seems like they're all treeitems

image

image
@JacksonKearl
Copy link
Contributor Author

Similar for status bar:

const sbi = vscode.window.createStatusBarItem(
	{
		id: 'dfsddsf', name: 'hello',
		accessibilityInformation: { label: 'I am also a label', role: 'checkbox' }
	})
sbi.text = 'My sbi'
sbi.command = 'solunar-timeline.log'
sbi.show()

image

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jul 1, 2020
@isidorn isidorn added this to the June 2020 milestone Jul 1, 2020
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2020
@isidorn isidorn closed this as completed in 1998567 Jul 1, 2020
@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2020

@JacksonKearl great catch. Since we were not changing the role of the status bar in practice we forgot to pass it through. Similar for the TimelineItem.
I have fixed this such that now the role should be respected when passed. Thanks!

@JacksonKearl JacksonKearl added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
3 participants
@isidorn @JacksonKearl and others