Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling provideTerminalLinks for empty lines #101452

Closed
eamodio opened this issue Jun 30, 2020 · 0 comments
Closed

Avoid calling provideTerminalLinks for empty lines #101452

eamodio opened this issue Jun 30, 2020 · 0 comments
Assignees
@Tyriar
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues
Milestone
July 2020

Comments

@eamodio
Copy link
Contributor

eamodio commented Jun 30, 2020

Testing #101300

While an extension can easily filter this, I think we should avoid the processing overhead when a line is missing or effectively blank.
@Tyriar Tyriar closed this as completed in 06b9d18 Jul 1, 2020
@Tyriar Tyriar added this to the July 2020 milestone Jul 1, 2020
@Tyriar Tyriar added terminal Integrated terminal issues polish Cleanup and polish issue labels Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@eamodio @Tyriar and others