Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some encodings can cause files to open corrupt #101905

Closed
bpasero opened this issue Jul 8, 2020 · 0 comments
Closed

Some encodings can cause files to open corrupt #101905

bpasero opened this issue Jul 8, 2020 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-encoding File encoding type issues file-io File I/O important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jul 8, 2020

Steps in #101856 still apply for insiders. The fix was only made for stable June release.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority file-io File I/O file-encoding File encoding type issues labels Jul 8, 2020
@bpasero bpasero added this to the July 2020 milestone Jul 8, 2020
@bpasero bpasero self-assigned this Jul 8, 2020
@bpasero bpasero mentioned this issue Jul 8, 2020
Closed
@bpasero bpasero changed the title Some encodings are not working Some encodings can cause files to open corrupt Jul 8, 2020
@bpasero bpasero closed this as completed in 0e96426 Jul 8, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@bpasero @gjsjohnmurray
🆙 iconv-lite-umd@0.6.8 (fix microsoft#101905)
df024fc
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 9, 2020
@bpasero @gjsjohnmurray
🆙 iconv-lite-umd@0.6.8 (fix microsoft#101905)
575b5a6
@isidorn isidorn added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@bpasero
🆙 iconv-lite-umd@0.6.8 (fix microsoft#101905)
a432527
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-encoding File encoding type issues file-io File I/O important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@bpasero @isidorn and others