Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCM] Action buttons are not always visible #102108

Closed
vasicsek opened this issue Jul 10, 2020 · 4 comments
Closed

[SCM] Action buttons are not always visible #102108

vasicsek opened this issue Jul 10, 2020 · 4 comments
Assignees
@joaomoreno
Labels
insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone
July 2020

Comments

@vasicsek
Copy link

vasicsek commented Jul 10, 2020 •
edited

I have an issue with the action buttons visibility. If my side panel width is not big enough and the names of my repositories are relative long I can not see the buttons. Below is a screenshot of the issue:

image

Also, there is no commit button, so I have to increase the width of the panel, which is not the best solution, because when I switch to the Explorer view is it is just wasted space.

image
image

  • VSCode Version: 1.47.0
  • OS Version: Windows 10 Pro 2004 19041.329

Steps to Reproduce:

  1. Add a repository with relative long name to Explorer
  2. Switch to Source Control panel

Does this issue occur when all extensions are disabled?: Yes
@joaomoreno
Copy link
Member

@vasicsek Do you have a suggestion on how to improve this?

@joaomoreno joaomoreno added scm General SCM compound issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues labels Jul 12, 2020
@joaomoreno joaomoreno added this to the July 2020 milestone Jul 12, 2020
@CreativeTechGuy
Copy link

This issue seems to have been introduced in a recent version as this previously wasn't an issue. When we have very long package names this tab is almost unusable as you'd need to expand the panel extremely wide just to click the buttons.

The suggestion is to force those action buttons to always be visible on the right side and truncate the repo name to fit the buttons. The buttons should take higher priority than the name.

@vasicsek
Copy link
Author

vasicsek commented Jul 12, 2020 •
edited

Sorry for the late answer. I agree with @CreativeTechGuy 's suggestion (thank you, btw) #102108 (comment). It seems an ideal solution for this issue.

@joaomoreno joaomoreno mentioned this issue Jul 16, 2020
Closed
@joaomoreno
Copy link
Member

Here's the fixed version:

image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
4 participants
@joaomoreno @vasicsek @CreativeTechGuy and others