Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging a file removes focus from the commit message box (regression) #102498

Closed
pvdstel opened this issue Jul 14, 2020 · 8 comments
Closed

Staging a file removes focus from the commit message box (regression) #102498

pvdstel opened this issue Jul 14, 2020 · 8 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone
July 2020

Comments

@pvdstel
Copy link

pvdstel commented Jul 14, 2020 •
edited

Version: 1.47.0 (system setup)
Commit: d5e9aa0
Date: 2020-07-09T08:02:06.629Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

This is a regression. A previous version of this bug was documented in #92401. This one is slightly different: typing simply does nothing. I did not find any issues related to the current stable version (1.47.0).

I've only tested it with Git.

Steps to Reproduce:

  1. Stage a file (using Git, or possibly another VCS)
  2. While the staging is in progress, type a commit message.
  3. The commit message box will lose focus once staging completes.

Does this issue occur when all extensions are disabled?: Yes

0001-0324
@realStandal
Copy link

I too am receiving this bug; same versions as stated above. The GIF, too, represents the same issue I'm running into.

@LachlanArthur LachlanArthur mentioned this issue Jul 15, 2020
Closed
@LachlanArthur
Copy link

Just mentioning git here as a keyword for future searches.

@yukuse
Copy link

yukuse commented Jul 15, 2020

It can also happen if you modify an unmodified file, save it, and then quickly focus the commit message box before Git detects the change.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Jul 15, 2020
@joaomoreno joaomoreno added this to the July 2020 milestone Jul 15, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Jul 15, 2020
Closed
@Dan503
Copy link

Dan503 commented Jul 16, 2020

This issue keeps coming back over and over. I think this is the 3rd or 4th time this bug has made it's way into production.

Can some sort of automated test be implemented to stop this issue from constantly coming back?

This is such an incredibly frustrating bug. :(

@gjsjohnmurray gjsjohnmurray mentioned this issue Jul 17, 2020
Closed
@usernamehw usernamehw mentioned this issue Jul 17, 2020
Closed
@gvlx
Copy link

gvlx commented Jul 17, 2020

Also on latest update:
Version: 1.47.2 (user setup)
Commit: 17299e4
Date: 2020-07-15T18:22:06.216Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 6.1.7601

@eldair
Copy link

eldair commented Jul 23, 2020

Same thing on 1.48

@usernamehw usernamehw mentioned this issue Jul 30, 2020
Closed
@gjsjohnmurray gjsjohnmurray mentioned this issue Jul 30, 2020
Closed
@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 1, 2020
Closed
@alexalannunes
Copy link

already fixed?

@pvdstel
Copy link
Author

pvdstel commented Aug 3, 2020

@alexalannunes Yup, it's fixed in the insiders release.

annkamsk pushed a commit to annkamsk/vscode that referenced this issue Aug 3, 2020
@joaomoreno
fixes microsoft#102498
096a492
@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 6, 2020
@usernamehw usernamehw mentioned this issue Aug 10, 2020
Closed
@usernamehw usernamehw mentioned this issue Aug 18, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
11 participants
@joaomoreno @gvlx @eldair @LachlanArthur @JacksonKearl @Dan503 @alexalannunes @pvdstel @yukuse @realStandal and others