Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift+enter stops working after opening notebook #102522

Closed
roblourens opened this issue Jul 14, 2020 · 3 comments
Closed

shift+enter stops working after opening notebook #102522

roblourens opened this issue Jul 14, 2020 · 3 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
July 2020

Comments

@roblourens
Copy link
Member

  • Open notebook
  • Open text editor
  • cmd+f to find, enter moves forwards, shift+enter does nothing

Some context key not being cleaned up
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jul 14, 2020
@roblourens roblourens added this to the July 2020 milestone Jul 14, 2020
@roblourens
Copy link
Member Author

roblourens commented Jul 14, 2020 •
edited

Maybe this is from the NOTEBOOK_CELL_LIST_FOCUSED change?

@roblourens
Copy link
Member Author

Related, sometimes NOTEBOOK_CELL_LIST_FOCUSED is false when the list is focused

@roblourens
Copy link
Member Author

This fix sucks, but this is another issue that would be solved by giving the notebook editor its own context key service

@isidorn isidorn added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
4 participants
@roblourens @rebornix @isidorn and others