Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs don't update column counter #103

Closed
DanielRosenwasser opened this issue Nov 18, 2015 · 7 comments
Closed

Tabs don't update column counter #103

DanielRosenwasser opened this issue Nov 18, 2015 · 7 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Dec 2015

Comments

@DanielRosenwasser
Copy link
Member

Repro:

  1. Hit the tab key
  2. Column count in gutter doesn't update

tabsdontupdatecolumns

Forgive the GIF quality.
@boyP
Copy link

boyP commented Nov 19, 2015

Hi, can I work on this bug?

@bpasero bpasero self-assigned this Nov 19, 2015
@bpasero
Copy link
Member

bpasero commented Nov 19, 2015

@boyP yes we do accept pull requests :).

@zhengqm zhengqm mentioned this issue Nov 19, 2015
Closed
@bpasero bpasero assigned alexdima and unassigned bpasero Nov 19, 2015
@bpasero
Copy link
Member

bpasero commented Nov 19, 2015

@alexandrudima not sure the fix is right, I can also change the editorStatus.ts to react on any types.

@alexdima
Copy link
Member

Indeed, I think the status bar should reflect the cursor state, regardless of the reason the cursor changed its state. So the fix should be made in editorStatus

@chrisdias chrisdias added the bug Issue identified by VS Code Team member as probable bug label Nov 21, 2015
@bpasero bpasero assigned bpasero and unassigned alexdima Nov 23, 2015
@alexdima
Copy link
Member

Thanks for fixing this!

@bpasero bpasero modified the milestone: Dec 2015 Nov 24, 2015
@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

❤️

@DanielRosenwasser
Copy link
Member Author

🎉 Thanks!

@bpasero bpasero added the verified Verification succeeded label Dec 15, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Dec 2015
Development

No branches or pull requests
5 participants
@bpasero @DanielRosenwasser @chrisdias @alexdima @boyP