Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-complete popup puts redundant "item" prefix per suggested code for screen readers #103095

Closed
jooyoungseo opened this issue Jul 22, 2020 · 4 comments
Closed

Auto-complete popup puts redundant "item" prefix per suggested code for screen readers #103095

jooyoungseo opened this issue Jul 22, 2020 · 4 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2020

Comments

@jooyoungseo
Copy link

CC @isidorn

This issue has been also filed on NVDA repo #11404, and confirmed that the fix has to be addressed on VSCode end.

System Info

Version: 1.48.0-insider (system setup)
Commit: 0a7364f
Date: 2020-07-22T05:49:27.463Z
Electron: 9.1.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Microsoft® Windows® Operating System Version 10.0.19041.1
NVDA v2020.1

Steps to Reproduce:

  1. With NVDA loaded, create any source code file in VSCode (e.g., test.py).
  2. Try using code suggestion feature (e.g., type cl and press Ctrl+Space and arrow-down to find class keyword).

Actual behavior:

NVDA and other screen readers (e.g., JAWS) keep announcing redundant prefix, "item," per suggested code in the auto-complete popup.

Expected behavior:

It would be ideal to filter out this prefix for NVDA users to quickly navigate through suggested code items.

Does this issue occur when all extensions are disabled?: Yes
@jooyoungseo jooyoungseo mentioned this issue Jul 22, 2020
Closed
@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2020

@jooyoungseo thanks for feedback. I have pushed a fix for this. You can try it out with vscode insiders from Wednesday and let us know if it is good for you.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug labels Jul 28, 2020
@isidorn isidorn added this to the July 2020 milestone Jul 28, 2020
@jooyoungseo
Copy link
Author

Thanks very much @isidorn! I will try that out on Wednesday, and keep you posted.

@jooyoungseo
Copy link
Author

I have confirmed that this issue has been resolved via the latest commit:

Version: 1.48.0-insider (system setup)
Commit: 15e798e
Date: 2020-07-28T10:39:18.007Z
Electron: 9.1.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

Thanks very much again @isidorn for this fix!

@isidorn
Copy link
Contributor

isidorn commented Jul 29, 2020

Great, thanks for letting us know. Adding verified label.

@isidorn isidorn added the verified Verification succeeded label Jul 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@isidorn @jooyoungseo and others