Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monaco uses outline-offset css which is not supported in IE/Edge #10330

Closed
alexdima opened this issue Aug 9, 2016 · 2 comments
Closed

Monaco uses outline-offset css which is not supported in IE/Edge #10330

alexdima opened this issue Aug 9, 2016 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2016

Comments

@alexdima
Copy link
Member

alexdima commented Aug 9, 2016

Basically, the bug is that Monaco uses the CSS “outline-offset” with high contrast styling, but this is not supported in IE (or Edge). See https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset. This results in some wacky looking scrollbar outlines, as shown below from Edge.

image
@alexdima alexdima added monaco-editor bug Issue identified by VS Code Team member as probable bug labels Aug 9, 2016
@alexdima alexdima added this to the August 2016 milestone Aug 9, 2016
@alexdima alexdima self-assigned this Aug 9, 2016
@Tyriar
Copy link
Member

Tyriar commented Sep 1, 2016

src/vs/base/browser/ui/messageList uses outline-offset, is anything in src/vs/base/ part of Monaco?

@bpasero bpasero added the verified Verification succeeded label Sep 2, 2016
@bpasero
Copy link
Member

bpasero commented Sep 2, 2016

Verified that we do not have outline-offset in base, platform and editor. The one in message list is not being used within the editor.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @alexdima