Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm.fetchOnlinePackageInfo is not respected in latest build #103540

Closed
ctf0 opened this issue Jul 29, 2020 · 3 comments
Closed

npm.fetchOnlinePackageInfo is not respected in latest build #103540

ctf0 opened this issue Jul 29, 2020 · 3 comments
Assignees
@aeschli
Labels
insiders-released Patch has been released in VS Code Insiders

Comments

@ctf0
Copy link

ctf0 commented Jul 29, 2020 

Version: 1.48.0-insider
Commit: 15e798e081984a17eae00de91adf4479190d5ed2
Date: 2020-07-28T10:40:03.139Z
Electron: 9.1.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. set "npm.fetchOnlinePackageInfo": false
  2. check any dep in package.json
  3. package info still being fetched

Does this issue occur when all extensions are disabled?: Yes
@Tyriar Tyriar assigned egamma and unassigned Tyriar Jul 29, 2020
@egamma egamma assigned aeschli and unassigned egamma Aug 4, 2020
@aeschli
Copy link
Contributor

aeschli commented Aug 12, 2020

You are correct, the hover would still make online requests. I push a fix.

Note that even with "npm.fetchOnlinePackageInfo": false it's still possible to get hovers and proposals when you have the npm command on the PATH.

@ctf0
Copy link
Author

ctf0 commented Aug 12, 2020

Note that even with "npm.fetchOnlinePackageInfo": false it's still possible to get hovers and proposals when you have the npm command on the PATH.

but how to disable it completely ?

@aeschli
Copy link
Contributor

aeschli commented Aug 12, 2020

There's no setting for that. But you can disable the npm extension.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@egamma @Tyriar @aeschli @ctf0 and others