Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue onDidWriteTerminalData events going to extensions hosts early on while they are being initialized #103697

Closed
Tyriar opened this issue Jul 31, 2020 · 6 comments
Closed

Queue onDidWriteTerminalData events going to extensions hosts early on while they are being initialized #103697

Tyriar opened this issue Jul 31, 2020 · 6 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues terminal Integrated terminal issues
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2020

Apparently even for Codespaces the initial events don't make it?
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues remote Remote system operations issues labels Jul 31, 2020
@Tyriar Tyriar added this to the Backlog milestone Jul 31, 2020
@Tyriar Tyriar self-assigned this Jul 31, 2020
@fara-nak
Copy link

Hi Daniel, can you please mark it as higher priority since we need this for our PortForwarding UI?

@Tyriar Tyriar modified the milestones: Backlog, August 2020 Aug 13, 2020
@Tyriar Tyriar closed this as completed in f542cd1 Aug 13, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2020

@fara-nak done, can you please verify this when you get the change?

@fara-nak
Copy link

i just checked in insider version 1.49 and issue still exist

@Tyriar
Copy link
Member Author

Tyriar commented Aug 14, 2020

@fara-nak guessing that the extension activation is happening too late after ext host spawn then.

@Tyriar Tyriar reopened this Aug 14, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Aug 14, 2020

Actually no, the buffered events are now sent when the first extension starts listening to onDidTerminalWriteData. @tara-nak are there multiple extensions listening and does it take the extension host longer than 10 seconds to launch?

@Tyriar Tyriar modified the milestones: August 2020, Backlog Aug 25, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Oct 12, 2021

Closing as this was done, it should only fail if the extension host/extension takes an unexpectedly long amount of time.

@Tyriar Tyriar closed this as completed Oct 12, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Oct 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@Tyriar @fara-nak and others