Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense position issue #10371

Closed
normalser opened this issue Aug 10, 2016 · 8 comments
Closed

Intellisense position issue #10371

normalser opened this issue Aug 10, 2016 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@normalser
Copy link

  • VSCode Version: Code - Insiders 1.5.0-insider (06d8543, 2016-08-09T16:02:06.523Z)
  • OS Version: Darwin x64 15.6.0

Steps to Reproduce:

  1. Have "wide" file and scroll to the right when intellisense is open
  2. image

Should probably stay within editor area

@joaomoreno
Copy link
Member

image

Can't seem to reproduce. Can you show me the screenshot including the whole window?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Aug 10, 2016
@normalser
Copy link
Author

Hope it helps:

bfhzar6gje

@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug intellisense and removed info-needed Issue requires more information from poster labels Aug 10, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Aug 10, 2016
@joaomoreno
Copy link
Member

cc @alexandrudima

@alexdima alexdima assigned alexdima and unassigned joaomoreno Aug 12, 2016
@joaomoreno joaomoreno added suggest IntelliSense, Auto Complete and removed intellisense labels Sep 27, 2016
@alexdima
Copy link
Member

alexdima commented Apr 9, 2018

The suggest widget should not be rendered when the cursor is not visible:

e.g.

kapture 2018-04-09 at 12 13 43

@alexdima alexdima modified the milestones: Backlog, April 2018 Apr 9, 2018
@roblourens
Copy link
Member

apr-25-2018 16-41-35

It can still fly out of the editor when the window is resizing.

@roblourens roblourens added the verification-found Issue verification failed label Apr 25, 2018
@roblourens roblourens reopened this Apr 25, 2018
@alexdima
Copy link
Member

I could reproduce. The root cause is no longer that the editor content widget positioning code is flaky, but that the suggest widget reports a very large width (also with transparent stuff, presumably where suggestion details might sit)

So, the problem is with the suggest widget which sizes itself at twice the width of the visible stuff inside of it:

image

@alexdima alexdima removed this from the April 2018 milestone Apr 26, 2018
@alexdima alexdima assigned ramya-rao-a and unassigned alexdima Apr 26, 2018
@ramya-rao-a
Copy link
Contributor

I've pushed a fix to not allocate space for the details/docs section until an item in the list does have details/docs to show.

This will help the above case where textual completions don't have any details/docs to begin with.

Note: This doesn't stop from the suggest widget to flowing into the side bar if there is no space.
But, it does make the suggest widget occupy the space right below the cursor rather than assuming that there are docs and having ghost space.

@ramya-rao-a ramya-rao-a removed the verification-found Issue verification failed label Jun 8, 2018
@ramya-rao-a ramya-rao-a added this to the June 2018 milestone Jun 8, 2018
@chrmarti chrmarti added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants