Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report UX issue when no source is selected #104472

Closed
oliversalzburg opened this issue Aug 12, 2020 · 5 comments
Closed

Bug Report UX issue when no source is selected #104472

oliversalzburg opened this issue Aug 12, 2020 · 5 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues verified Verification succeeded
Milestone
August 2020

Comments

@oliversalzburg
Copy link

Issue Type: Bug

When no source is selected under "File on", the "Preview on GitHub" button should be clearly disabled. The form cannot be sent unless a source is picked. The dialog does not reflect the invalid state of the UI or direct the user towards the missing input.

VS Code version: Code 1.47.3 (91899dc, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard
Remote OS version: Linux x64 4.19.104-microsoft-standard
Remote OS version: Linux x64 4.19.104-microsoft-standard
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3672)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 63.91GB (36.52GB free)
Process Argv --folder-uri=vscode-remote://wsl+Ubuntu/home/oliver/fairmanager/backend/core-web3 --remote=wsl+Ubuntu
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.104-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3672)
Memory (System) 50.14GB (39.13GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.104-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3672)
Memory (System) 50.14GB (39.13GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.104-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3672)
Memory (System) 50.14GB (39.13GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.104-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3672)
Memory (System) 50.14GB (39.13GB free)
VM 0%
Extensions (25)
Extension Author (truncated) Version
eslint-disable-snippets drK 1.2.0
vscode-docker ms- 1.4.1
remote-containers ms- 0.128.0
remote-ssh ms- 0.51.0
remote-ssh-edit ms- 0.51.0
remote-wsl ms- 0.44.4
vscode-remote-extensionpack ms- 0.20.0
vscode-icons vsc 10.2.0
better-toml bun 0.3.2
vscode-eslint dba 2.1.8
eslint-disable-snippets drK 1.2.0
gitlens eam 10.2.2
EditorConfig Edi 0.15.1
prettier-vscode esb 5.1.3
vs-code-xml-format fab 0.1.5
generateuuid Fir 0.0.5
shell-format fox 7.0.1
terraform has 2.1.1
vscode-esformatter how 1.6.0
code-beautifier mic 2.3.3
vscode-docker ms- 1.4.1
vscode-paste-image mus 1.0.4
vscode-xml red 0.13.0
vscode-yaml red 0.9.1
lit-plugin run 1.2.1

(2 theme extensions excluded)
@RMacfarlane
Copy link
Contributor

Currently, validation is performed when clicking "Preview on GitHub", which should highlight any missing fields:

Screen Shot 2020-08-12 at 8 29 51 AM

Would showing a validation message next to these fields help?

@oliversalzburg
Copy link
Author

It's probably a problem with my theme then:
image

Only now am I seeing the faint asterisks in my UI too.

Maybe a message would help to ensure themes don't interfere.

@RMacfarlane RMacfarlane added issue-reporter Issue reporter widget issues bug Issue identified by VS Code Team member as probable bug labels Aug 12, 2020
@RMacfarlane RMacfarlane added this to the August 2020 milestone Aug 12, 2020
@RMacfarlane
Copy link
Contributor

I added a validation message:
Screen Shot 2020-08-12 at 10 45 45 AM

@oliversalzburg
Copy link
Author

Nice. I'm sure it will save me in the future. Thanks 😊

@GitMensch
Copy link
Contributor

@RMacfarlane can you please add a "Preview in Editor" button (sorry for the short-cut of not creating an issue, they tend to get lost very easy and you've adjusted the UX two days ago)? I'm using vscode one a restricted system without any internet access, and can't use it because of the missing "offline" option.

@mjbvz mjbvz added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
5 participants
@oliversalzburg @RMacfarlane @GitMensch @mjbvz and others