New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right Click on Extension Search > Peek causes freeze #104727
Comments
I have the same problem |
This is also there in settings editor Assigning to @roblourens since this is a bug in Suggest enabled input. |
I'm not sure about the freeze, I don't repro that. But @jrieken can you just make sure that peek command won't show up in the simple editor input? I changed the Command Palette one to have |
Hm, this must be a regression from @joaomoreno's submenu changes as the Peek-menu is quite old already. Will look into a fix, also marking as candidate |
I have pushed a change so that the sub menu doesn't show anymore. Tho, I cannot reproduce the freeze. Not on mac nor on windows. I wonder if that's related to the welcome page not showing recent entries... Can you try without the welcome page or with a different workspace? |
Adding @sbatten for more insights and FYI. You might know more about the crash potential - it seems that sometimes the Peek menu doesn't expand and than the crash happens. In my testing (win/mac) I wasn't able to repro and got the menu with a single, disabled entry |
@jrieken That is the cause, You need to right click then quickly left click as if you're trying to get the peek to show with a left click; don't wait for the peak to show. I just realized that was the exact step to reproduce the error. By clicking before the menu shows I can repo it 100% of the time, unless I am slow clicking. |
Yep, It doesn't have to be from the search bar, it can be anywhere. Not sure if this is it, but seems to be it. from https://github.com/microsoft/vscode/blob/master/src/vs/editor/contrib/peekView/peekView.ts
|
Thanks @topherhoffman 👏 Once I am fast enough I can reproduce. There is an endless loop creating the submenu and trying to focus an item. Not quite sure why this only happens when being fast... |
I believe this was introduced via 182db07 because it adds the |
I have cherry-picked my commit fa4ee50 onto the release branch which should make this not happen anymore - tho the underlying issue and the potential for this endless loop remains |
Thanks for cherry picking. Due to that closing this issue so we get it verified for the release. |
To verify:
|
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes/No
Yes, Still happens
The text was updated successfully, but these errors were encountered: