Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle-click on a link doesn't open the link properly #104776

Closed
eamodio opened this issue Aug 17, 2020 · 5 comments · Fixed by #104885
Closed

Middle-click on a link doesn't open the link properly #104776

eamodio opened this issue Aug 17, 2020 · 5 comments · Fixed by #104885
Assignees
@jrieken @alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2020

Comments

@eamodio
Copy link
Contributor

eamodio commented Aug 17, 2020

I have muscle memory for middle-clicking on links (to open in a new tab) and it doesn't work in VS Code.

image

If I middle-click on the link above, it opens a browser to file:///C:/Users/Eric/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/code/electron-browser/workbench/workbench.html
@jrieken jrieken assigned bpasero and alexdima and unassigned jrieken Aug 17, 2020
@bpasero
Copy link
Member

bpasero commented Aug 17, 2020

@eamodio are you using VSCode in Electron or Web? Does it work when you click normally and if so what happens then?

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 17, 2020
@eamodio
Copy link
Contributor Author

eamodio commented Aug 17, 2020

This is in Electron (haven't tried on the web). And it works perfectly on a normal click.

@bpasero bpasero added this to the August 2020 milestone Aug 17, 2020
@bpasero bpasero added editor-hover Editor mouse hover help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Aug 17, 2020
@bpasero
Copy link
Member

bpasero commented Aug 17, 2020

OK, making this open for help if someone wants to chime in.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 17, 2020
jeanp413 added a commit to jeanp413/vscode that referenced this issue Aug 18, 2020
@jeanp413
Fixes microsoft#104776
ace080a
@jeanp413 jeanp413 mentioned this issue Aug 18, 2020
Merged
@jeanp413
Copy link
Contributor

Created a PR #104885 to fix this

@bpasero bpasero assigned jrieken and unassigned bpasero Aug 18, 2020
@bpasero
Copy link
Member

bpasero commented Aug 18, 2020

History shows @jrieken as the one introducing the click handler but I am not sure who the owner is today.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Fixes middle-click on a link doesn't open the link properly jeanp413/vscode
7 participants
@eamodio @bpasero @jrieken @RMacfarlane @alexdima @jeanp413 and others