Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test task detail #105737

Closed
3 tasks done
alexr00 opened this issue Aug 31, 2020 · 3 comments
Closed
3 tasks done

Test task detail #105737

alexr00 opened this issue Aug 31, 2020 · 3 comments
Labels
testplan-item
Milestone
August 2020

Comments

@alexr00
Copy link
Member

alexr00 commented Aug 31, 2020 •
edited by sana-ajani

Refs: #69785

Complexity: 2

Create Issue

The built-in npm extension has used the API for months. Things to verify:

  • Take a look a the use of this API in the npm extension. Verify that it makes sense.
  • Verify that the doc comments make sense.
  • Verify that when you run the Configure Task command and choose an npm task, that the detail gets copied into the tasks.json.
  • Verify that when you run Run Task and choose the npm folder that the npm tasks have a detail.
  • Verify that the setting task.quickOpen.detail controls whether the detail is shown.
@alexr00 alexr00 added this to the August 2020 milestone Aug 31, 2020
@jrieken jrieken mentioned this issue Sep 1, 2020
Closed
@jrieken jrieken removed their assignment Sep 1, 2020
@lszomoru
Copy link
Member

lszomoru commented Sep 1, 2020

👏🏻

@lszomoru lszomoru removed their assignment Sep 1, 2020
@sana-ajani
Copy link
Contributor

sana-ajani commented Sep 2, 2020 •
edited

@alexr00 nice! minor comment on the "task.quickOpen.detail" setting, should we edit it to be:

"Controls whether to show the task detail for tasks that have a detail in the Run Task and Configure Task quick pick"
image

@alexr00
Copy link
Member Author

alexr00 commented Sep 3, 2020

New string for setting: "Controls whether to show the task detail for tasks that have a detail in task quick picks, such as Run Task."

alexr00 added a commit that referenced this issue Sep 3, 2020
@alexr00
Fix string for task detail setting
8fcec32 
Part of #105737
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
5 participants
@jrieken @lszomoru @RMacfarlane @sana-ajani @alexr00