Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering debug console commands while a filter is applied is weird #105863

Closed
roblourens opened this issue Sep 1, 2020 · 5 comments
Closed

Entering debug console commands while a filter is applied is weird #105863

roblourens opened this issue Sep 1, 2020 · 5 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2020

Comments

@roblourens
Copy link
Member

Testing #105185

  • Start debugging
  • Enter a filter in the debug console
  • Type some command in the debug console input and execute it
  • I don't see the input or the output unless they match the filter.

I can't really decide whether this is good or bad, I can imagine a situation where I want to filter the console.logs coming in but I still want to run code and see the result. I can also imagine wanting to filter my inputs/outputs. Chrome DevTools actually just never applies the filter to inputs/outputs. But if they are filtered, it seems like they should be filtered together (like I always see the input+output together or not at all, they aren't filtered separately)
@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2020

All makes sense. But what would you suggest that we do here?
Chrome DevTools usualy makes smart design decisions and we can be inspired by them and also not apply the filter on user input/output pairs.

fyi @weinand @connor4312

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Sep 1, 2020
@kieferrm
Copy link
Member

kieferrm commented Sep 2, 2020

I stumbled over the same issue. I'd prefer when a filter is active it is not applied to the commands I type and what they return.

@connor4312
Copy link
Member

connor4312 commented Sep 2, 2020 •
edited

I like the approach of chrome devtools only applying the filter to their equivalent of "output" events. I think that's a good approach: always show any explicit input and results in the console.

@weinand
Copy link
Contributor

weinand commented Sep 2, 2020

@connor4312 yes, I like the chrome devtools approach too.

@isidorn
Copy link
Contributor

isidorn commented Sep 3, 2020

Yeah, let's go with that approach.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 3, 2020
@isidorn isidorn added this to the August 2020 milestone Sep 3, 2020
@isidorn isidorn closed this as completed in fd913ac Sep 3, 2020
@connor4312 connor4312 added the verified Verification succeeded label Sep 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
6 participants
@roblourens @weinand @isidorn @connor4312 @kieferrm and others