Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debouncing seems too short #105977

Closed
kieferrm opened this issue Sep 2, 2020 · 3 comments
Closed

Debouncing seems too short #105977

kieferrm opened this issue Sep 2, 2020 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2020

Comments

@kieferrm
Copy link
Member

kieferrm commented Sep 2, 2020

Testing #105185

It seems to me that the debouncing is too short. When I arrow up and down through the history I see something like "conso" followed by "console" rather than just "console". I tried that several times and I think my typing speed is OK, i.e. there is no perceived time gap between any of the characters.
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 2, 2020
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Sep 3, 2020
@isidorn isidorn added this to the August 2020 milestone Sep 3, 2020
@isidorn isidorn closed this as completed in c367d61 Sep 3, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 3, 2020

Agree. I have increased the delay from 200ms to 400ms both for Debug Console and the Problems view.
fyi @sandy081

@connor4312 connor4312 added the verified Verification succeeded label Sep 3, 2020
@connor4312
Copy link
Member

Verified the debounce is better.

But I think a nicer heuristic might just be to save a history item when either focus is lost, or the input contents are cleared.

@isidorn
Copy link
Contributor

isidorn commented Sep 4, 2020

@connor4312 good idea, we can try to tackle that in the future also for the problems and the debug console filter.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
5 participants
@weinand @isidorn @connor4312 @kieferrm and others