Also affects Windows. It's a regression, it used to work with 1.48.
keybindings.json testcase:

    {
        "key": "ctrl+f",
        "command": "-workbench.action.terminal.focusFind",
        "when": "terminalFocus"
    }

@spasche Hi Spasche, I found this bug with the 1.49.
It used to work with the 1.48 on MacOS as well.

It seems it's not possible to remove other keybindings as well. None of these work to remove ctrl+f when in the terminal:

[
  {
    "key": "ctrl+k f",
    "command": "workbench.action.terminal.focusFind",
    "when": "terminalFindFocused && terminalProcessSupported || terminalFocus && terminalProcessSupported"
  },
  {
    "key": "ctrl+f",
    "command": "-workbench.action.terminal.focusFind",
    "when": "terminalFindFocused && terminalProcessSupported || terminalFocus && terminalProcessSupported"
  },
  {
    "key": "ctrl+f",
    "command": "-actions.find",
    "when": "terminalFocus && terminalProcessSupported"
  }
]

This works:

{ "key": "ctrl+f", "command": "-workbench.action.terminal.focusFind" }

I'm guessing the issue is that && and || don't work when you're removing keybindings. Maybe we should have a warning for such removal keybindings if this is by design?

Testcase on #106524 (comment) also doesn't work and doesn't contain && or || in the when condition.

So the issue may not be related to && or || (or not only).

@spasche good point, tested and I can see that too. Updated title.

Yup, this does not work:

    {
        "key": "ctrl+f",
        "command": "-workbench.action.terminal.focusFind",
        "when": "terminalFocus"
    }

This does:

    {
        "key": "ctrl+f",
        "command": "-workbench.action.terminal.focusFind"
    }

This is a problem limited for now to the terminal actions and it has to do with the way the default keybindings are constructed in code by using AND between the precondition and the when context. So the registration of workbench.action.terminal.focusFind leads to a when expression looking like:

(terminalFindFocused || terminalFocus) && terminalProcessSupported.

But the context keys do not support parentheses in their serialized form (that is intentional), so we distribute the AND against the OR to create:

terminalFindFocused && terminalProcessSupported || terminalFocus && terminalProcessSupported.

Unfortunately there is a bug in that code path where the normalized form is not fully equal to the deserialized form. The normalized form contains an extra AND expression with a single operand which should be removed:

The workaround is to remove the keybindings without a "when" clause.