Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview content overlaps some other panel borders #106612

Closed
n-gist opened this issue Sep 14, 2020 · 6 comments
Closed

Webview content overlaps some other panel borders #106612

n-gist opened this issue Sep 14, 2020 · 6 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Milestone
September 2020

Comments

@n-gist
Copy link
Contributor

n-gist commented Sep 14, 2020 •
edited

Webview content overlaps other panel borders

Hi! Just noticed this (red arrows).
There is 1px padding/margin noticeable also (green arrow).
It spoils the clarity a bit in some color themes. Does not happen on default theme.
Noticed when was using Git Graph extension, but its author pointed that it happens with other extensions: mhutchie/vscode-git-graph#380

  • VSCode Version: 1.49.0 (user setup)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open some folder with git repository
  2. Install Gist Theme color theme
  3. Install Git Graph extension
  4. Open Git Graph main window (button in status bar)
  5. Open Output panel and sidebar (sidebar is on the right side on screenshots below)

Webview (Git Graph) tab:
ov1
File tab:
ov2
@mjbvz
Copy link
Contributor

mjbvz commented Sep 15, 2020 •
edited

Please fill in the issue template

Also which color them are you using?

@mjbvz mjbvz added the ~info-needed Issue requires more information from poster (with bot comment) label Sep 15, 2020
@n-gist
Copy link
Contributor Author

n-gist commented Sep 15, 2020

Updated

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues and removed info-needed Issue requires more information from poster labels Sep 15, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Sep 15, 2020

Thanks

@mjbvz mjbvz added this to the September 2020 milestone Sep 15, 2020
@mjbvz mjbvz closed this as completed in cacb77c Sep 15, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 1, 2020
@rzhao271
Copy link
Contributor

rzhao271 commented Oct 1, 2020

So the excess padding indicated by the red arrows are fixed.
As for the excess padding indicated by the green arrow, I wonder whether that's an issue specific to the Gist Theme itself?

gist-theme-padding-issue

@n-gist
Copy link
Contributor Author

n-gist commented Oct 1, 2020 •
edited

As for the excess padding indicated by the green arrow, I wonder whether that's an issue specific to the Gist Theme itself?

I confirm this is caused by using window.activeBorder, window.inactiveBorder parameters, which, when used, offset the content of the entire window. The previous fix might not be needed if these parameters weren't shifting it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
September 2020
Development

No branches or pull requests
4 participants
@rzhao271 @mjbvz @n-gist and others