Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot read property 'className' of null #10820

Closed
bpasero opened this issue Aug 23, 2016 · 2 comments
Closed

TypeError: Cannot read property 'className' of null #10820

bpasero opened this issue Aug 23, 2016 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
August 2016

Comments

@bpasero
Copy link
Member

bpasero commented Aug 23, 2016

When switching "open editors" view from visible to hidden or vice versa.

@isidorn it looks like when the view changes, it does not get disposed and so old listeners are hanging around?
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Aug 23, 2016
@bpasero bpasero added this to the August 2016 milestone Aug 23, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 23, 2016

No, the view gets properly disposed, however when reacting to icon changes we were acting on configuration changes before the whole explroer view would get constructed. Added a null guard to protect against that
fyi @aeschli

@bpasero
Copy link
Member Author

bpasero commented Aug 23, 2016

I added that code btw.

bpasero added a commit that referenced this issue Aug 24, 2016
@bpasero
improve fix for #10820
c4f3652
@bpasero bpasero added the verified Verification succeeded label Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
2 participants
@bpasero @isidorn