Remote-SSH removes query parameters on editor file: URIs #110377
Labels
author-verification-requested
Issues potentially verifiable by issue author
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
remote-connection
verified
Verification succeeded
Milestone
Steps to Reproduce:
This is rather a specific issue - currently in my extension I open a diff editor, but in order to provide context commands for that editor, I also need to have some additional information about the diff / file for use in the context menu items. I've done this by encoding that additional information in the
query
portion of the URI for the right hand diff.This works ok locally, but in remote-SSH the query parameters disappear so I can't get that information back when running the context commands
I suspect that it's presumably rewriting URIs into vscode-remote:// URIs and back again, and losing the query params in the process.
It also works ok for non
file:
URIs as they presumably are not rewrittenPossibly I "shouldn't" be encoding params into
file:
URIs but I haven't yet found a better way to store this context reliablyedit: I've spotted some other problems with using query params on file URIs (cpp extension causes errors, editor windows are out of sync when not saved) and I've discovered another way of doing almost all of what I need, using the
isInDiffEditor
andisInRightDiffEditor
contexts, so I think I'm going to rework this part of my extension to avoid doing this. But I'll leave this here for now as it may be something you want to look into?file:
URI including a non-emptyquery
string in the editor.Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No
The text was updated successfully, but these errors were encountered: