Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code crashes if you exit the launching process #1109

Closed
latkin opened this issue Dec 8, 2015 · 3 comments
Closed

Code crashes if you exit the launching process #1109

latkin opened this issue Dec 8, 2015 · 3 comments
Assignees
@bpasero
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
Backlog

Comments

@latkin
Copy link

latkin commented Dec 8, 2015

  • Start cmd
  • Launch VS Code from prompt
  • Close cmd

Expected: VS Code continue to run
Actual: Just before closing, cmd displays [VS Code]: render process crashed, and both cmd and Code exit

Screencap from right after X-ing out of cmd:

image

Version 0.10.3
Commit 783ecf841a2b21edca6d86853670cae89b4c244f
Date 2015-11-26T14:06:31.538Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 9, 2015
@bpasero bpasero added this to the Backlog milestone Dec 9, 2015
@bpasero
Copy link
Member

bpasero commented Dec 9, 2015

This might be fixed with future versions of Electron, I saw something...

@egamma egamma added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 15, 2015
@latkin
Copy link
Author

latkin commented Dec 20, 2015

Likely related, also strange:

  • Launch Code via code.exe from the terminal
  • Go about your business
  • At some point, break out of any other action in that terminal via Ctrl + C

Code will mysteriously exit. Somehow it's listening for Ctrl + C from the parent process?

ctrlc

@latkin latkin mentioned this issue Dec 20, 2015
Closed
@bpasero
Copy link
Member

bpasero commented Apr 3, 2016

Please reopen if this still happens with our latest cli work.

@bpasero bpasero closed this as completed Apr 3, 2016
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Apr 11, 2016
@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Tyriar added a commit that referenced this issue Aug 20, 2019
@Tyriar
Ensure resolved cwd is passed back to window
0b4c4dc 
Fixes #1109
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@egamma @bpasero @latkin