Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty untitled file should not show up as dirty #11554

Closed
ghost opened this issue Sep 5, 2016 · 3 comments
Closed

Empty untitled file should not show up as dirty #11554

ghost opened this issue Sep 5, 2016 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2016

Comments

@ghost
Copy link

ghost commented Sep 5, 2016

  • VSCode Version: 1.4
  • OS Version: ubuntu 16.04 LTS

Steps to Reproduce:

  1. create empty file
  2. write something
  3. delete the content
  4. try to close
  5. you will be asked:

Do you want to save the changes you made to Untitled-1?

Why that question? ... the content is empty and a file does still not exist.
@ghost
Copy link
Author

ghost commented Sep 6, 2016

@leo90skk I'd like to fix this. This disrupts my workflow and is becoming very tedious.

@bpasero
Copy link
Member

bpasero commented Sep 6, 2016

Yes, we should fix this.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 6, 2016
@bpasero bpasero added this to the September 2016 milestone Sep 6, 2016
@bpasero bpasero self-assigned this Sep 6, 2016
@bpasero bpasero changed the title Aksing for saving empty file Empty untitled file should not show up as dirty Sep 6, 2016
@bpasero bpasero closed this as completed in 5e92eb1 Sep 6, 2016
@bpasero
Copy link
Member

bpasero commented Sep 6, 2016

Verify: once you make an untitled buffer empty, it is not dirty anymore.

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@bpasero @ramya-rao-a