Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to prevent closing the pinned tab when using middle click #115734

Closed
lonix1 opened this issue Feb 4, 2021 · 3 comments · Fixed by #188592
Closed

Add setting to prevent closing the pinned tab when using middle click #115734

lonix1 opened this issue Feb 4, 2021 · 3 comments · Fixed by #188592
Assignees
@bpasero
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders keep Issues we should not close as out of scope verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone
August 2023

Comments

@lonix1
Copy link

lonix1 commented Feb 4, 2021

I wanted to add this as a comment to #100738, but it's been locked.

A pinned tab cannot be closed with ctrl + w, but it can be closed with the mouse (middle click).

Please extend this behavior so the middle click cannot close a pinned tab?
@vscodebot
Copy link

vscodebot bot commented Feb 4, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues labels Feb 4, 2021
@bpasero bpasero removed their assignment Feb 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
@lonix1 lonix1 mentioned this issue Jul 21, 2023
Closed
@bpasero bpasero reopened this Jul 21, 2023
@bpasero bpasero modified the milestones: Backlog Candidates, Backlog Jul 21, 2023
@bpasero bpasero added the keep Issues we should not close as out of scope label Jul 21, 2023
@bpasero bpasero changed the title Prevent closing the pinned tab when using middle click Add setting to prevent closing the pinned tab when using middle click Jul 21, 2023
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Jul 21, 2023
@weartist weartist mentioned this issue Jul 23, 2023
Merged
@microsoft microsoft unlocked this conversation Jul 24, 2023
weartist added a commit to weartist/vscode that referenced this issue Jul 25, 2023
@weartist
Revert "Fix: Add setting to prevent closing the pinned tab when using…
121952a 
… middle click (microsoft#115734)"

This reverts commit aac0052.
@bpasero bpasero self-assigned this Jul 27, 2023
@bpasero bpasero modified the milestones: Backlog, August 2023 Jul 27, 2023
bpasero added a commit that referenced this issue Jul 28, 2023
@weartist @bpasero
Add setting to prevent closing the pinned tab when using middle click (…
55b75c5 
…fix #115734) (#188592)

* Fix: Add setting to prevent closing the pinned tab when using middle click (#115734)

* Revert "Fix: Add setting to prevent closing the pinned tab when using middle click (#115734)"

This reverts commit aac0052.

* add setting for prevent closing the pinned tab when using middle click

* Adjust the description

* Adjust 'pinned' to 'sticky

* adjust prevent close pinned tab related code

* 💄

* some cleanup

* setting description

* fix logic

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 28, 2023
@lonix1
Copy link
Author

lonix1 commented Jul 28, 2023

@weartist This has been bugging me for years. Thank you so much for implementing this!
And thanks @bpasero for reopening the issue. I can't wait for the next version!

@bpasero
Copy link
Member

bpasero commented Jul 28, 2023

Setting is called workbench.editor.preventPinnedEditorClose and can be configured to block editor close for mouse, keyboard, keyboardAndMouse or never.

This change will actually also set keyboardAndMouse as the default, which means all users will see the behaviour of not being able to close a pinned tab with middle mouse click unless the setting is changed. Will see how many complaints we get.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2023
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 24, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Aug 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders keep Issues we should not close as out of scope verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Add setting to prevent closing the pinned tab when using middle click (fix #115734) weartist/vscode
5 participants
@bpasero @joyceerhl @lonix1 @VSCodeTriageBot and others