-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimalEditOperations can break formattings #11593
Comments
@egamma fyi |
Thanks for digging into this @jrieken! |
@jrieken What about formatting not working at all (rather than messing with characters)? Are we talking about the same thing? Taken from the original issue:
|
Why close this issue? Is it being tracked elsewhere? |
@jrieken Sorry for not following you on this: have you closed the issue because if was fixed by ce1f925? And also, what do you mean by not having "reproducible steps"? For starters, you have a complete project uploaded here from where you can replicate the issue. But, nevertheless, if you would like to see the formatter in action, just create a new C# project and start playing around with the "Format Code" option. It'll take you no more than two minutes to realize that formatting C# scripts just does not work on VSCode. If you really need them for some reason, you can certainly create your own steps - like I did in my previous comment. |
@nfantone: based on the analysis in dotnet/vscode-csharp#660, I was guessing that the bad edits were hitting some fail safe in the editor that caused it to start ignoring the command. |
@DustinCampbell All right. But which one is it? An analysis or a guess? Is this still happening on |
It's a guess based on incomplete analysis. 😄 Once there's a new insider's build, we'll know more. |
@DustinCampbell @jrieken I'm happily reporting that after updating Insider, formatting now works again on all my Unity projects! Cheers for that. One minor thing: I had to remap my formatting binding on MacOSX from |
Now... if only there were a way of configuring format settings consistently across IDEs... |
@DustinCampbell @jrieken Same here - formatting is now working as expected on all my Unity projects on Windows 10. |
Thanks |
Steps in dotnet/vscode-csharp#660 (comment). Regression from 'fixing' #10133
The text was updated successfully, but these errors were encountered: