Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger viewlet not choosing the right target #11653

Closed
octref opened this issue Sep 7, 2016 · 4 comments
Closed

Debugger viewlet not choosing the right target #11653

octref opened this issue Sep 7, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@octref
Copy link
Contributor

octref commented Sep 7, 2016

  • VSCode Version: 1.5.0 Insider
  • OS Version: OS X 10.11.6

Steps to Reproduce:

  1. Clone Microsoft/vscode
  2. Open the folder using VSCode Insider. Make sure chrome debugger extension is not installed.
  3. Choose Unit Test in debug viewlet, and enable a breakpoint that will be hit.
  4. When the breakpoint is hit, change the target to Launch VSCode (which has type: chrome).
  5. Click Run icon. It falls back to Unit Test instead of running Launch VSCode or produce an error saying "Debug type chrome is not supported".

debug-viewlet-wrong-target

@ramya-rao-a ramya-rao-a added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 8, 2016
@ramya-rao-a
Copy link
Contributor

Is it even a valid operation to change launch configurations in the middle of a debug session?

@octref
Copy link
Contributor Author

octref commented Sep 8, 2016

@ramya-rao-a
If it's invalid I think the dropdown should be grayed out. The current behavior is unexpected.

Other than that, changing the target and relaunching also has the same problem.

Maybe you can add a UX tag.

@weinand weinand assigned isidorn and unassigned weinand Sep 8, 2016
@weinand
Copy link
Contributor

weinand commented Sep 8, 2016

@isidorn I've seen something like this too. For me it typically happens for the same debug type: first I run a launch config "test", then I switch to launch config "server" and press the green start button. Later, when waiting for the server to startup, I notice that the tests are running again...

I believe this is a timing issue (race condition). While a debug session is running, it should not be possible to switch the launch config. But sometimes it seems to be possible. However, when the debug sessions ends the new launch config is switched back to old launch config.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Sep 8, 2016
@isidorn isidorn added this to the September 2016 milestone Sep 8, 2016
@isidorn isidorn closed this as completed in 0056109 Sep 8, 2016
@roblourens roblourens reopened this Sep 29, 2016
@roblourens
Copy link
Member

You can still change launch configs while debugging, if you hide/show the debug sidebar.
sep-28-2016 17-15-37

@roblourens roblourens added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants