This is how the suggest widget accept on enter behaves also in the editor.
We should be consistent. Thus assigning this to @jrieken to consider if it should be changed everywhere.

Disagree - the editor and the repl are different beasts and accepting inserting a new line whenever you auto complete doesn't make sense in the editor. I am pretty sure @isidorn is aligned on that. Either change the default for the repl or tell users to do so - the change should be trivial, just preprint ^ to key. That tells the service to trigger listeners but still handle the events as if it would do without keybindings

preprint ^ to key

@jrieken Thanks for the tip, but what exact key do you mean? I tried preprinting it to the currentWord but that did not work.

Sorry, prepend to the command id, like we do it here in TypeScript which means. Bind . to run the command and insert dot-character.

Thanks @jrieken this works however as you said this makes the suggestion be accepted and the listeners triggered - which in my world means a new line is added on enter(editor reacted on the listener). I would need two of my actions to be exectued, suggestion accepted and repl input accepted and only in the special case that the input matches the whole selection. Not sure if this is possible.

For comparison chrome dev tools always evalutes on enter and never acceppts the suggestion - I am also against that since it is much different behavior than our editor. Also the user can configure this via "editor.acceptSuggestionOnEnter": false

I wasn't trying to say what the repl should do. Surely this isn't a default for the normal text editor, for the repl maybe and iff not it the configuration users have to do

Decided that this is less frustrating than #18751
So reopening and will have to do a proper solution for this one in the future - something similar to what chrome dev tools are doing

fyi @jrieken this is the issue I was mentioning in the standup
I was searching through suggest widget feature requests but could not find the one you mentioned that people already want this.

Assigning also to @jrieken and moving to the next milestone to potentially look into it then

related to #15702. There is two options: Hide items that will result in a no-op or make Enter insert a newline for those items

I have now implemented this, which is keeping perfect matches but not binding Enter for those.

@jrieken OMG awesome. I owe you at least one beer for this!
Tried it out in the debug console and it works like a charm -> thus closing this.