VS Code hangs when update dependencies #12042

michaeljota · 2016-09-14T19:24:32Z

VSCode Version: 1.5.2
OS Version: Windows 10 (AU)

Steps to Reproduce:

Open a proyect fresh cloned.
Run npm install in a (external) terminal.

VS Code stop responding. I ran it with the integrated terminal and an external one with the same results.

Edit typo.

The text was updated successfully, but these errors were encountered:

bpasero · 2016-09-15T04:50:45Z

@michaeljota does this produce a top level node_modules folder? can you share your settings?

michaeljota · 2016-09-15T12:44:45Z

I notice this with top level node_modules only. Have not tried with any other. What settings do you need? I don't have settings changed from the editor, just few extensions.

I got Sync Settings, I can give you the gist url, but it's just the list of extensions.

bpasero · 2016-09-15T13:34:55Z

I am wondering if this is file event related and you changed the built in files.watcherExclude setting in any way?

michaeljota · 2016-09-15T13:52:44Z

It happens to me with differents projects, not just one.

bpasero · 2016-09-15T13:55:18Z

@michaeljota can you share your user settings and workspace settings or at least see if you once configured this setting files.watcherExclude?

michaeljota · 2016-09-15T13:59:07Z

I don't have any user settings not workspace settings. I have not configured files.watcherExclude.

You can see my settings here

bpasero · 2016-09-15T14:10:21Z

@michaeljota does this reproduce with any kind of npm install? I am wondering if the amount of modules getting installed has an impact. E.g. can we try with a small package.json that maybe only has one dependency to see if it reproduces?

michaeljota · 2016-09-15T15:12:26Z

With this files hangs

{
  "name": "angular2",
  "version": "0.0.1",
  "dependencies": {
    "@angular/common": "2.0.0-rc.7",
    "@angular/compiler": "2.0.0-rc.7",
    "@angular/core": "2.0.0-rc.7",
    "@angular/forms": "2.0.0-rc.7",
    "@angular/http": "2.0.0-rc.7",
    "@angular/platform-browser": "2.0.0-rc.7",
    "@angular/platform-browser-dynamic": "2.0.0-rc.7",
    "@angular/router": "3.0.0-rc.3",
    "core-js": "^2.4.1",
    "rxjs": "5.0.0-beta.12",
    "zone.js": "^0.6.21"
  }
}

Let me try something smaller.

EDIT:
This small does NOT hang

{
  "name": "angular2-desktop",
  "version": "0.0.1",
  "dependencies": {
    "@angular/common": "2.0.0-rc.7",
    "@angular/compiler": "2.0.0-rc.7",
    "@angular/core": "2.0.0-rc.7"
  }
}

Neverless, they are random package. But, I reproduce the problem with the first one.

bpasero · 2016-09-19T04:54:38Z

@michaeljota
I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

ghost · 2016-09-19T12:40:20Z

I have the same issue. When running npm i VScode freezes and npm fails because of file/folder lock caused by VScode.

Normal start vs. --disable-extensions
When starting VScode in normal mode, VScode shows a popup asking about Keep waiting or closing the windows. Regardless of my choice VScode never recovers.

When starting VScode with --disable-extensions it's very laggy. Moving the cursor from row to row feels like running VScode on an old 486 CPU or something. But at least it doesn't die.

The following issues persist regardless of enabled or disabled extensions.

npm complains about insuficient permissions because it can't rename/move files&folders at the finishing stage.

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\denny.trebbin\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "i"
npm ERR! node v6.6.0
npm ERR! npm  v3.10.8
npm ERR! path C:\code\js\products\sfi.sebn.com\backend\node_modules\.staging\ajv-keywords-38f0ca98
npm ERR! code EPERM
npm ERR! errno -4048
npm ERR! syscall rename

npm ERR! Error: EPERM: operation not permitted, rename 'C:\code\js\products\sfi.sebn.com\backend\node_modules\.staging\ajv-keywords-38f0ca98' -> 'C:\code\js\products\sfi.sebn.com\backend\node_modules\ajv-keywords'
npm ERR!     at destStatted (C:\Users\denny.trebbin\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:25:7)
npm ERR!     at FSReqWrap.oncomplete (fs.js:123:15)
npm ERR!
npm ERR! Error: EPERM: operation not permitted, rename 'C:\code\js\products\sfi.sebn.com\backend\node_modules\.staging\ajv-keywords-38f0ca98' -> 'C:\code\js\products\sfi.sebn.com\backend\node_modules\ajv-keywords'
npm ERR!     at Error (native)
npm ERR!  { Error: EPERM: operation not permitted, rename 'C:\code\js\products\sfi.sebn.com\backend\node_modules\.staging\ajv-keywords-38f0ca98' -> 'C:\code\js\products\sfi.sebn.com\backend\node_modules\ajv-keywords'
npm ERR!     at destStatted (C:\Users\denny.trebbin\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:25:7)
npm ERR!     at FSReqWrap.oncomplete (fs.js:123:15)
npm ERR!
npm ERR! Error: EPERM: operation not permitted, rename 'C:\code\js\products\sfi.sebn.com\backend\node_modules\.staging\ajv-keywords-38f0ca98' -> 'C:\code\js\products\sfi.sebn.com\backend\node_modules\ajv-keywords'
npm ERR!     at Error (native) parent: 'sfi_backend' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\code\js\products\sfi.sebn.com\backend\npm-debug.log

But npm can't rename/move files because VScode locked many of them. Maybe for scanning them?
VSCode locked a lot of files.

Process Explorer shows interesting stuff.

Notice, I have just 1 VScode app running in Process Explorer I see two apps. The one at the bottom of the image has no sub-processes, not sure what's about it.

bpasero · 2016-09-19T12:48:34Z

@fibric can you hover over the processes in process explorer to find out their command line arguments? this would help finding out which process is hogging CPU

ghost · 2016-09-20T10:30:18Z

@bpasero sorry, it took me a while; I have no Windows machine at home.

With the Insiders update from today, I don't see the alien process anymore.

bpasero · 2016-09-24T06:08:10Z

@michaeljota you still there?

@fibric in those screenshots I am not seeing a process with high CPU though? you say you cannot reproduce in insiders?

ghost · 2016-09-24T08:17:38Z

Oh well, I forgot about it.
I took the before pictures but forgot about the when-it's-happinging pictures. I'll do that on Monday when I'm in office again.

michaeljota · 2016-09-24T15:23:10Z

@bpasero I'm here, but I don't know what program is that. Witch you would recommend me?

bpasero · 2016-09-24T16:05:18Z

@michaeljota a tool to see the full command line arguments of the processes (https://technet.microsoft.com/en-us/sysinternals/processexplorer.aspx?f=255&MSPPError=-2147217396). it would allow us to find the process that consumes so much CPU for you.

ghost · 2016-09-26T11:33:25Z

I have only two processes which steal a lot of CPU time while running npm i. The freeze+hang situation seems to be gone now.

In the user preferences, I found a search option

{
...,
  // Configure glob patterns of file paths to exclude from file watching. Changing this setting requires a restart. When you experience Code consuming lots of CPU time on startup, you can exclude large folders to reduce the initial load.
  "files.watcherExclude": {
    "**/.git/objects/**": true
  },
...,
  // Configure glob patterns for excluding files and folders in searches. Inherits all glob patterns from the files.exclude setting.
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true
  },
...
}

I added "**/node_modules": true, to files.watcherExclude just to be save. The CPU consumption is still very high but VScode doesn't freeze&hang anymore; it's just a bit unresponsive while npm i runs.

bpasero · 2016-09-26T12:13:14Z

@fibric yes you definitely want to have node_modules in the excludes and they are by default (maybe you configured it once when it was not yet):

"files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/node_modules/**": true
}

ghost · 2016-09-26T13:16:01Z

On my VScode installation, node_modules isn't defined by default.

bpasero · 2016-09-26T13:45:51Z

@fibric sorry you are right, we only exclude it on Mac and Linux where our file watcher is not very efficient for large folders. We do not have seen this issue on Windows yet.

bpasero · 2016-09-28T09:31:11Z

@michaeljota
To find out more about this issue, we need to get at the process that is causing the high load. VS Code creates multiple processes, each with different tasks. Depending on your OS you can get at the full command line of the process and paste it here. On Mac, the Activity Monitor allows to find the PID of the process and from a terminal ps aux | grep <pid> reveals its arguments.

On Windows a tool like Process Explorer helps:

Once you have the information please update this issue with it. Thanks!

ghost · 2016-09-29T12:11:00Z

Sorry, for forking. I was in a hurry. I apologize.
#13024

bpasero · 2016-09-29T13:43:10Z

@fibric ok, now you are forking this issue into something else I think because this originally was about hang when running "npm install". please create a new issue for your CPU issue when opening a large file.

michaeljota · 2016-10-05T14:48:38Z

OK. Just tried to npm install and in VS Code 1.5.3 this is not longer an issue. Seems to be fixed to me. If someone else can confirm would be better, but I'm not able to reproduce this again.

I tried in two different projects, and neither reproduce the issue.

bpasero · 2016-10-05T14:56:35Z

OK please report back then if it happens again. However since this seems to happen sporadically, it seems like an indeterministic issue.

michaeljota · 2016-10-05T15:17:10Z

Sure. Thanks! Sorry for the delay.

michaeljota · 2016-11-21T13:47:42Z

@bpasero I'm sorry, but I'm having this same issue with lastes stable Code (1.7.1).

You can run npm install with this repo to reproduce the issue. angular2-ultimate-starter.

The screens from Process Explorer:

User config:

// Coloque su configuración en este archivo para sobrescribir la configuración predeterminada.
{
    "editor.fontFamily": "Hasklig, Consolas, 'Courier New', monospace"
}

Workspace config:

{
  "typescript.tsdk": "node_modules/typescript/lib/",
  "auto-close-tag.activationOnLanguage": [
    "html"
  ],
  "typescriptHero.resolver.multiLineWrapThreshold": 100
}

Extensions: (Installed. Recommended in workspace as well)

{
  // See http://go.microsoft.com/fwlink/?LinkId=827846
  // for the documentation about the extensions.json format
  "recommendations": [
    // Extension identifier format: ${publisher}.${name}. Example: vscode.csharp

    "abusaidm.html-snippets",
    "christian-kohler.path-intellisense",
    "EditorConfig.EditorConfig",
    "eg2.tslint",
    "formulahendry.auto-close-tag",
    "formulahendry.auto-rename-tag",
    "joelday.docthis",
    "johnpapa.Angular2",
    "msjsdiag.debugger-for-chrome",
    "natewallace.angular2-inline",
    "rbbit.typescript-hero"
  ]
}

michaeljota · 2016-11-21T13:49:24Z

If you need anything else, I'll try to help you. This issue is really edge, but with this configuration for some reason keeps happing. I work with that seed in my projects, and in everyone of them it's the same. I have to close VSCode when I'm going to install.

bpasero · 2016-11-21T13:54:37Z

@michaeljota
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

michaeljota · 2016-11-22T12:55:11Z

@bpasero it is still reproducible.

bpasero · 2016-11-23T06:34:06Z

@michaeljota I tried to reproduce and could not. in your screen shots I am also not seeing a CPU spending high cycles in some task, how does the lag show to you then? does VS Code freeze? Also can you share your settings with me?

michaeljota · 2016-11-23T12:56:18Z

I already share them, settings and extension set, just after my set of pictures. The VSCode freeze and ask for reload.

The CPU usage does not get high, it just "stop responding".

michaeljota · 2017-01-20T12:43:34Z

@bpasero Hi! I reproduce this with another, and smaller, project.

Steps:

Open project
Small styles edit to the first file that opens
(in an external console) npm install nodemon -D. Maybe it's worth to notice how many dependencies nodemon has.
Comeback to VSCode to see it freeze.

package.json

{
  "name": "graphql-postgres",
  "version": "1.0.0",
  "description": "An example GraphQL server using a PostgreSQL DB",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "tsc": "tsc"
  },
  "author": "Michael De Abreu",
  "license": "MIT",
  "dependencies": {
    "express": "^4.14.0",
    "express-graphql": "^0.6.1",
    "faker": "^3.1.0",
    "graphiql": "^0.8.1",
    "graphql": "^0.8.2",
    "pg": "^6.1.2",
    "pg-hstore": "^2.3.2",
    "sequelize": "^3.29.0",
    "ts-node": "^2.0.0",
    "typescript": "^2.1.5"
  },
  "devDependencies": {
    "@types/express": "^4.0.35",
    "@types/express-graphql": "0.0.33",
    "@types/faker": "^3.1.32",
    "@types/graphql": "^0.8.6",
    "@types/node": "^6.0.60",
    "@types/pg": "^6.1.34",
    "@types/sequelize": "^4.0.39",
    "nodemon": "^1.11.0",
    "react": "^15.4.2",
    "react-dom": "^15.4.2"
  }
}

tsconfig.json (for reasons)

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": true,
    "sourceMap": true,
    "noEmitHelpers": true,
    "strictNullChecks": false,
    "baseUrl": "./src",
    "paths": {
    },
    "lib": [
      "dom",
      "es6",
      "es2017"
    ],
    "noUnusedParameters": true,
    "noUnusedLocals": true,
    "noImplicitReturns": true
  }
}

User settings.json

// Coloque su configuración en este archivo para sobrescribir la configuración predeterminada.
{
    "editor.fontFamily": "Hasklig, Consolas, 'Courier New', monospace",
}

Workspace settings.json

{
    "typescript.tsdk": "./node_modules/typescript/lib"
}

Extensions

johnpapa.Angular2
natewallace.angular2-inline
formulahendry.auto-close-tag
formulahendry.auto-rename-tag
msjsdiag.debugger-for-chrome
joelday.docthis
EditorConfig.EditorConfig
christian-kohler.path-intellisense
eg2.tslint
rbbit.typescript-hero

It's literally a five files project.
graphql-postgres.zip

Explorer Process Screens

VSCode frozen

bpasero · 2017-01-20T13:36:49Z

@michaeljota I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

bpasero · 2017-03-15T16:30:23Z

@michaeljota is this still happening with our latest insider build? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

michaeljota · 2017-03-15T19:58:04Z

I see what you did there. I'll test it and report. 👍

bpasero · 2017-05-14T07:57:23Z

Let's merge into #3998

michaeljota mentioned this issue Sep 14, 2016

Crash prompt to reload window does not work in all cases #12043

Closed

bpasero added the info-needed Issue requires more information from poster label Sep 15, 2016

bpasero added this to the Backlog milestone Sep 15, 2016

bpasero self-assigned this Sep 15, 2016

bpasero added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues and removed info-needed Issue requires more information from poster labels Sep 15, 2016

bpasero added the info-needed Issue requires more information from poster label Sep 15, 2016

bpasero reopened this Oct 5, 2016

bpasero closed this as completed Oct 5, 2016

bpasero reopened this Nov 22, 2016

bpasero removed the info-needed Issue requires more information from poster label Nov 22, 2016

bpasero modified the milestones: November 2016, Backlog Nov 22, 2016

bpasero modified the milestones: Backlog, November 2016 Nov 23, 2016

bpasero added the info-needed Issue requires more information from poster label Nov 23, 2016

tinesoft mentioned this issue Feb 11, 2017

VS Code freezes when removing 'node_modules' folder from external terminal, forcing to close #20480

Closed

bpasero added a commit that referenced this issue Feb 23, 2017

ignore file watching in node_modules on windows (for #12042)

490b297

bpasero added the workbench label Apr 7, 2017

bpasero closed this as completed May 14, 2017

bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 14, 2017

bpasero added the file-watcher File watcher label Jun 8, 2017

vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

VS Code hangs when update dependencies #12042

VS Code hangs when update dependencies #12042

Comments

michaeljota commented Sep 14, 2016 • edited

bpasero commented Sep 15, 2016

michaeljota commented Sep 15, 2016

bpasero commented Sep 15, 2016

michaeljota commented Sep 15, 2016

bpasero commented Sep 15, 2016

michaeljota commented Sep 15, 2016

bpasero commented Sep 15, 2016

michaeljota commented Sep 15, 2016 • edited

bpasero commented Sep 19, 2016

ghost commented Sep 19, 2016 • edited by ghost

bpasero commented Sep 19, 2016

ghost commented Sep 20, 2016 • edited by ghost

bpasero commented Sep 24, 2016

ghost commented Sep 24, 2016

michaeljota commented Sep 24, 2016

bpasero commented Sep 24, 2016

ghost commented Sep 26, 2016

bpasero commented Sep 26, 2016 • edited

ghost commented Sep 26, 2016

bpasero commented Sep 26, 2016

bpasero commented Sep 28, 2016

ghost commented Sep 29, 2016 • edited by ghost

bpasero commented Sep 29, 2016

michaeljota commented Oct 5, 2016 • edited

bpasero commented Oct 5, 2016

michaeljota commented Oct 5, 2016

michaeljota commented Nov 21, 2016

michaeljota commented Nov 21, 2016

bpasero commented Nov 21, 2016

michaeljota commented Nov 22, 2016

bpasero commented Nov 23, 2016

michaeljota commented Nov 23, 2016 • edited

michaeljota commented Jan 20, 2017

bpasero commented Jan 20, 2017

bpasero commented Mar 15, 2017

michaeljota commented Mar 15, 2017

bpasero commented May 14, 2017

michaeljota commented Sep 14, 2016 •

edited

michaeljota commented Sep 15, 2016 •

edited

ghost commented Sep 19, 2016 •

edited by ghost

ghost commented Sep 20, 2016 •

edited by ghost

bpasero commented Sep 26, 2016 •

edited

ghost commented Sep 29, 2016 •

edited by ghost

michaeljota commented Oct 5, 2016 •

edited

michaeljota commented Nov 23, 2016 •

edited