Could be due to this

I was looking at this when debugging the problem, however, the vscode debugger for extensions doesn't work perfectly when it starts to dig into the vscode code. One work around I was thinking of that I couldn't find a way to do, is simply check if the file is currently showing in one of the editor windows. However it appears the only related call is the getter for activetexteditor, but this only gives you the active editor for the current window in focus.

Is there a way to get the active editors for all the open windows? I.E can you get the editor that is currently open in the other windows when you have 2 or 3 files open side by side?

I think visibleEditors gives all the ones that are visible. But that one has the problem that it is lacking an event.

It seems checking visibleEditors works around the problem. Thanks for the reference.

This problem affects Dart Code - I was going to try and implement this workaround, but the show method on TextEditor is marked as deprecated:

* @deprecated **This method is deprecated.**
* Use window.showTextDocument instead. This method shows unexpected behavior and will be removed in the next major update.

Is there any other workaround for this that won't break in an upcoming update?

window.showTextDocument seems to have performance problems (1-1.5 second promise resolve) when calling it with a document that is already in focus.

@anthonydresser @DanTup Is opening the same document in the same editor column (basically a no-op) the slow case or when opening the same document in another column?

@jrieken The no-op scenario is slow too. Our code is like this:

vs.workspace.openTextDocument(location.file).then(document => {
    vs.window.showTextDocument(document).then(editor => {
        let range = toRange(location);
        editor.revealRange(range, vs.TextEditorRevealType.InCenterIfOutsideViewport);
        editor.selection = new vs.Selection(range.end, range.start);
    });
});

We open the document then need the editor so that we can jump to the correct place. Even when everything is in one file there's a second delay between this code executing and the selection moving (inside the same file).

Understood. The 1 second might come from here but I was assuming openEditor returns the editor when it's already open...

Actually, this should be easy to fix

Great! Let me know if you'd like me to test with our code once it's in Insiders.

Thanks - should be in insiders on Monday

@jrieken this is working great in Insiders now, it's instant with no delay 👍

Marking as verified as per @DanTup's confirmation