Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event utils leakage #123487

Closed
3 of 7 tasks
jrieken opened this issue May 10, 2021 · 8 comments
Closed
3 of 7 tasks

Event utils leakage #123487

jrieken opened this issue May 10, 2021 · 8 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented May 10, 2021

We have a bunch of event-utils which internally create an Emitter. These emitters are never disposed and are therefore leaking. The following can use

  • "owner" creates an event
  • consumer subscribes to event and never disposes it
  • owner is being disposed
  • event listener is still there and leaks whatever is "connected" to the emitter

@jrieken jrieken assigned jrieken and joaomoreno and unassigned jrieken May 10, 2021
@jrieken jrieken added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label May 11, 2021
joaomoreno added a commit that referenced this issue May 11, 2021
@joaomoreno
Copy link
Member

@jrieken What do you think? 4ed31ca

@joaomoreno joaomoreno added this to the May 2021 milestone May 11, 2021
@jrieken
Copy link
Member Author

jrieken commented May 11, 2021

Yeah, I like. Tho, I am afraid that Emitter#dispose isn't calling onLastListenerRemove. Tho, that should be an easy fix, let me how it goes

@joaomoreno
Copy link
Member

Oh I just assumed that would work. Yeah let's do that.

@jrieken jrieken modified the milestones: May 2021, June 2021 May 28, 2021
joaomoreno added a commit that referenced this issue Jun 9, 2021
@joaomoreno
Copy link
Member

I have removed all usages of domEvent and replaced them with:

  • addDisposableListener, whenever no events were really needed
  • DomEmitter, whenever some event logic was in use

@connor4312
Copy link
Member

connor4312 commented Oct 7, 2021

While these aren't disposed, are these utilities actually leaky? The Emitter is side-effect free, so--provided all consuming listeners are disposed of--the Emitter created by snapshot should be disposed of in normal garbage collection.

If bidirectional disposal is required, snapshot could use a WeakRef to cascade the deletion.

Things like filter and map are super useful. It would be a shame to have to get rid of them without replacing them.

@jrieken
Copy link
Member Author

jrieken commented Oct 7, 2021

provided all consuming listeners are disposed of

Yeah, it's exactly for those cases. We had leakage cascade with the domListener-util where consumer/listener wouldn't dispose their subscription and then leak much.

This current idea is to turn some utils, like debounce into debounceListener, e.g don't return new events but a smarter subscription. The chaining is going away, the idea is to start with one entry which later must be disposed, like Event.chain(event).map(..).filter(..).debounce(...) The result of that sausage is has an event and a dispose call.

@connor4312
Copy link
Member

Interesting. Let me know if you want help, I've worked a lot on rxjs which has similar semantics and requirements in its subscribers and observers.

@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Oct 19, 2021
jrieken added a commit that referenced this issue Nov 3, 2021
@joaomoreno joaomoreno added this to the November 2021 milestone Nov 9, 2021
benoitf added a commit to benoitf/che-code--old that referenced this issue Nov 10, 2021
0600ecc75b0 Fix problem location URI Fixes #136588
5ce44b2e016 feat(grid): :children_crossing: 2x2 mode can be enabled by splitting
2c4eb0298dd errors - do no log undefined rejection reasons
cfb6bc83c9f fix(scm): :zap: dont create event listeners per scm row
37a3ce24f03 cleanup proposed api
e54933ab221 Remove initial text line skipping in tasks Part of #136585
3b2089f7b48 Merge pull request #136402 from smcenlly:main
7d78ec2e1df Merge pull request #136543 from jzyrobert/html_correct_command
3ba528bde5b don't show "Activating Extensions..." repeatedly
00d94046fe7 fix preinstall script (#136638)
8d5348aba63 web - rewrite how storage is handled on shutdown
bdbaac08a1d :lipstick:
80c789277f1 Stop parcel watcher on shutdown (#136569)
a7104f13ff6 Remove unused fs import #133654
f8c479c0a7f Merge branch 'microsoft:main' into main
3afa5c64200 - Do not send replace content from ext host - implement replaceAll in the model - cancel all model update operations on replace request - queue append operation after replace - clean ups
e034d59a8e9 Merge branch 'main' into pr/smcenlly/136402
66b1668b667 wait if there's a refresh in progress
b2185337aa3 Fix #118835 to check ListSelectionNavigation
82c003a9883 Update to use nullExtensionDescription instead of undefined when no extension is available in Host Outpu `ExtHostLogFileOutputChannel` context
292793d9fbf fixes #136451
73c9f9853d0 Fix slashes in windows test
d1f2d0a7296 Tweak markdown notebook header sizes
0fb0d013678 Remove searchApp, searchIpc And update search settings for local search removal #133654
8a18a669fea fix: performance issues on large context menus (#136398)
5993f56abe1 Remove LocalSearchService, again Fix #133654
3df135c388e Fix jupyter version number, #136544
29c5f2d3948 Show an error when opening an old unsupported jupyter format Fix #136544
69ca0f29fdc Enable linkify in notebook markdown
1a98c6a1e8f 💄
7b4e7d399f9 Add order field to the settings json schema (#133484)
8d78e70f782 Update html-language-features documentation and tasks to yarn
b13351b6119 Prevent standard browser find widget showing when inside webviews
7c0bb3bac60 enable experiments not available in shared process
b2c4948b9c7 Update telemetry extractor
c15b08173c7 Bump distro
76dab1d2f7e Simplify list.clear Fix #118835
950e89beacf replace ProcessPropertyType with generic T (#136469)
3b39182f079 trigger min height update when output height is non-zero
0f9d05ca5b1 Remove externalURLOpener embedder API
f3dd2158ca1 Update Codicons: Add `newline` https://github.com/microsoft/vscode-codicons/commit/482a516fd42a0a0262725638300ba0fe0c106bbf
60af1d383ca allow hover of detail. Fixes #101874
e5bcb02e1e9 fix(tree): :bug: allow navigating between breadcrumbs using arrow keys
b5ac86ad3e1 Change log level trace to info in auto tasks Part of microsoft/vscode-remote-release#5309
e4efcb3be9b Drive letter on Windows remotes Fixes #135762
4297ff8195c Revert fix for #26425
c7a84f93d36 Address no-async-promise-executor ESLint rule
eaaf68f7ae1 fix(list): Escape should shrink selection first
d0755ba4bb7 :lipstick:
120ddb6053d Honor setting show only shortcut keys (#136251)
3d3e502e722 Allow ts files for gulp tasks Fixes #136418
6ef5dbec55f _forwardMarkers must check for empty markerData, fixes https://github.com/microsoft/vscode/issues/136434
9d092bc97a8 Fixes #136470 by not firing "onDidChange" when there was no change.
2b250d99855 extract iconNameCharacter from doParseLabelWithIcons
2499f319496 fix https://github.com/microsoft/vscode/issues/133622
05a2f2809e4 Don't show 'Sync Changes' button if auto sync or auto push are enabled (#134408)
b59f00fc4d2 fix (again) https://github.com/microsoft/vscode/issues/133210
3b6a33dc07b inlay hints - properly dispose scroll listener
8e2f1765b60 Update replaceAllCancellationToken cancellation to use optional chaining operator instead of if statement
1cd23628b3a Address some feedback from pull request: https://github.com/microsoft/vscode/pull/136402
552af97a017 Add a welcomeView message when no debugger extensions are enabled Fix #136450
8a4ddd5643e Revert "user agent testing"
08ef40bd522 Clairify webview names
8e3bfab216e Initial support for the webview find widget on web
dd075fadbc3 Use ?.
06fe6b7d2ba Bump browser TS version
1051cf402eb Unmark preview as experimental
87bb81422f1 Ensure is mirrored is set
8e96e0b389a #fix: 108459 (#108666)
206975e91ed user agent testing
6dd03037c26 Update collector++ endpoint
88d7502f322 include ~ in possible icon name. fixes #136172
c11a9ce0972 Better update of line numbers
28d3032473d fix #135097.
2c083a7bc92 Fix errors in typings
74f5177f758 update slack channel
0cc0f5f2346 try to fix publish types
14d89d8dc0e restore terminal color, icon, and name on restart (#136454)
e31a18ea8c6 Editors - pathsToEditors should ignore folders (#136359)
8ad817b486c notebook: remove debug code
e8667df1082 notebooks: still prefer built-in renders, but add equivalence for 1st party jupyter ones
6dc49ed3a5a testing: allow selecting text from test peek
e932a05b28e Update telemetry extractor
fb722748796 clean up
47b332ecf81 remove support for @optional service dependencies, https://github.com/microsoft/vscode/issues/119440#issuecomment-961164634
68957a66bb1 add ability for embedders to specify urls that should open in a popup with opener (#136383)
1c0f29d4a9c Update version
18e854aa339 Elevate if needed when restoring ports Fixes microsoft/vscode-remote-release#5776
3afe0282277 Remove optional usage from external terminal
b555ad16c5f Mark `::before` and `::after` users as deprecated
6aaf18c33be Merge pull request #136368 from microsoft/tyriar/127878
ca0fe119520 Merge remote-tracking branch 'origin/main' into tyriar/127878
a0019c16423 Update web telemetry validation
999ef6915e9 Don't show tasks error on folder open Fixes #135803
05b2c57917f send an event per mark
f411e1cffbd if profile name is null return undefined  (#136438)
b2c343d085a send telemetry for resource performance marker
eadf1c41528 Merge remote-tracking branch 'origin/main' into tyriar/127878
273470f94ac Move disableWorkspaceTrust to the workbench layer
b88c19f2f29 Gets rid of "config.editor.useInjectedText" in ghost text widget, as injected text is now considered stable.
ce2764c70c9 Merge pull request #136353 from microsoft/hediet/prefix-sum-minus-one
a28d33aa6c8 Merge pull request #136296 from microsoft/hediet/refactoring1
43fa8b44291 Merge pull request #136371 from microsoft/aeschli/browseThemes
8e7d7299d38 :lipstick: min column of peek arrow is 2 because at column 1 it gets cropped
7c4052f9e68 up scrollbar size from 3px to 6px, https://github.com/microsoft/vscode/issues/116338
5250f425aa6 chore -a little less registerThemingParticipant
bccd9b904b2 Add logging around invoking the resolver (microsoft/vscode-remote-release#5811)
2e35efaaef2 Merge pull request #136375 from adaex/update-seti-ui
b389529e97d fix smoke test "verifies settings"  - problems view is not getting update when not visible.
e396e26abca polish _installedExtensions
f9e8dc20955 :up: playwright
fc03bd35180 Fix eslint duplicate key error
516bc19e999 Fix md preview reverting to original version when switching away
4d50e586ec3 Improve morphing for vscode-docs
3d565d9d8e9 fix #125961.
6b0816e2c4f Merge branch 'microsoft:main' into main
323e7fd6536 Recompute editor height when collapse state changes Fix #136400
3d6c93b5e3b fix #136362
88c39ebdf05 Add "collapse/expand all" commands Fix #129488
a14ebdfec4d Remove inputCollapsed and outputCollapsed metadata, make them view properties Fix #125274
2f1e5cb85f8 don't show welcome view when web extension terminal is created (#136327)
fd21ba32591 fix #130669.
960ed2bddc3 fixes #80767
a704a69394a Enforce that source code uses a small subset of Unicode
3247c31f6a4 Replace Right Single Quotation Mark with Single Quote
1aa9a712d19 Allow extensions to disable built-in markdown preview button (#136273)
ce9c6361dc0 Remove typescript-vscode-sh-plugin
a046cfb4818 Revert "Remove image stabilizer code"
1f3f74f4eaa Clear this._fileWatchersBySrc
86c446baeef Don't update icon path so much
87802c41fb8 Add readonly to iconPath properties
9c2b239e2e0 Remove image stabilizer code
359cd4330de clean up onDidChangeActiveTextEditor
d42476c5755 Cleaning up code examples in vscode.d.ts
97e646c0da4 Update preview if text document is reopened
a9a61174250 Improve `createCodeEditorServices` (#136380)
513d5806563 Improve `createModelServices` (#136380)
fab12653546 #135941 Use diffIdentityProvider while setting children
ebd2d0ae7b6 Fix terminal process manager test
30d286606d7 Update to latest seti-ui icon theme
a81beeedae4 Some terminal profile service test improvements
657e3da4f60 Fix terminal profile service test
3caa4241138 refactor
9291d82351c make renderer-side parts splash ready for web
980fbb65b90 one less usage of debounce, https://github.com/microsoft/vscode/issues/123487
64933517cc0 Remote IOffProcessTerminalService
c60efa236d3 Remote RemoteTerminalService
c55fd10ad86 Create RemoteTerminalBackend
a865bed813e Kill ripgrep process when file search is cancelled. Previously we only cancelled the part of the search that happens in our process, not the actual rg process. Fix #135936
c08e8fac576 extension configure button
00ac42efe95 Delete LocalTerminalService
86cc0a8af93 notebook layout caveats
3e6039efb44 Fix simple file dialog save as when filenames overlap Fixes #135838
7adb0ee21f0 Fix tilda replacement in simple file picker
db37d4484cf add theme color for suggest status, https://github.com/microsoft/vscode/issues/134326
b1084be4dad Fix remote terminals by using RemoteTerminalService again temporarily
32fbe4c4003 Only allow tilda shortcut at beginning of path Fixes #135375
50712aa581c Remove all @optional injections
78394284d5c Fix ports view action alignment Fixes #135305
8ef66a20ab8 Fix unit tests
b52be018386 Start replacing ILocalTerminalService with a registered backend
29edcf2a4f6 Order of task sources, include custom tasks for build Fixes #134605
5829f824b83 Fix #136259
c937ab0fb6b Fix #127789
fe00fa4d27c clean up
b0c00c21434 Force task terminals to be in the view Part of #134533
4d3d471c992 getPrefixSum(indexInclusive) -> getPrefixSum(count: indexInclusive + 1)
44435f33e15 Fixes #116939: Escape unicode directional formatting characters when rendering control characters. Also turn on `editor.renderControlCharacters` by default.
eeaeb28558c Remove no longer necessary license text
44caa5a52b8 Remove console.log
1944e5d1335 Fix #135935
21a828f217a Improves LineBreakData test
eec6ed94de6 Exposes and adopts IViewLineTokens.getLineContent
435410dbf85 chore - use real CSS theme variables in language status and kernel view item
ea27d603a6c chore - use CSS theme variables over registerThemingParticipant, codeLens, references, call hierarchy
4ed0329e9c5 #135935 move IUriIdentityService to platform
0e72666f280 Refactors line break data.
0847eebd73a web - adopt indexDB helper for storage
f2d3a235b6b Browse themes from MP
bfa488dd8f2 watcher - use `type` property for crash reporter location
3ff2cd942d8 remove `ms-vscode.remotehub*` from proposed API allow list, https://github.com/microsoft/vscode-internalbacklog/issues/2431#issuecomment-950869327
02d4cb5383c Unable to resolve your shell pops-up instantly (fix #136272)
af261488f85 watcher - enable crash reports on linux (#136264)
b64259260d7 Merge branch 'microsoft:main' into main
0603dcd867c Add replaceAll method to OutputChannel to improve render flickering for extensions with minimal output contents; associated with https://github.com/microsoft/vscode/issues/132183
fd3b9ada8e8 Fix #135093
c17da20cbad Fix #131675
662b9779e80 Update execution order support when kernel changes Fix #122639
6fca14b7792 Fix #133015
2c390625bca fix #136318
cbc49837434 fixes #127756
bfcc4f8f223 Fix #135395
717a622b3c4 Fixes #136170 (#136171)
bf4ede862d6 remove vscode prefix for exp name
9c2cb612068 add more terminalProfileService tests (#136308)
fe8ee4ce8f4 Fix #135477
8b20926d708 Add descriotion to walkthrough
8b8e1d1dfaf Fix up markdown centering
d9ef7784b5c Update collector++ endpoint
773e643dd86 Merge pull request #136292 from microsoft/tyriar/more_xtermterminal
338b390cdb9 Fix #129733 Fix #125400
e6080fd7238 :lipstick:
83d551ba583 fix #132101.
a4906e7a151 fix #133929.
45e8ea48867 Narrow list of word separators. Fixes #123915
5d87d648cb5 Create TerminalProfileService (#136131)
3db1aad8fbb Exp => Assignment Rename (#136253)
86974a77bbc Revert "Remove unused search process code"
be9522f78ce Fix unreliable terminal splitting for depends tasks Fixes #134431
adc6ff82096 clean up
2948450d50c clean up
e06d19cfbcd Fix #136295
b135abf2933 Merge remote-tracking branch 'origin/main' into tyriar/more_xtermterminal
c3be8a8cc0f Ignore :in at the end of word links when searching
09bce4765fe Move xterm core into XtermTerminal
57ede3b21f8 Move terminal target management into XtermTerminal
9efc116de0e Update grammars
0577803a099 Merge pull request #136177 from jeanp413/fix-135596
c65e5c71e7c Remove _xtermElement
629f832a1e9 Move xterm core into XtermTerminal
426022916bc Move terminal target management into XtermTerminal
61cd6437a0c Fix timing bug for back-to-back CustomExecution tasks Fixes #131926
bf34d474a1f lifecycle :lipstick:
2fea2964928 web - always reload when we detect persisted pageshow
e06da97af6e web - refactor lifecycle service to always go through before, will, did shutdown phases
fd04883947f Reorders LineBreakData constructor arguments to better model their logical dependency.
c49848e3f5d 💄
c4e1daa46dd Fix #133324
94e38fd15d3 chore - use CSS theme variables for file decoration colors
d5c42c8c3e6 chore - use CSS color variables for suggest
e40d668b5f9 chore - use CSS color variables for snippets
c755f01fe87 chore - use CSS color variables for in-editor messages
d5417f9f815 chore - for "workspace edit preview" use CSS color variables instead of `registerThemingParticipant`
d5db92d1f57 add theme colors as css variables, fyi @alexdima, @aeschli
019867139e8 api feedback
1cdfddffe98 Uses array queue.
827639c994d Fix #136275
f86dd64be63 Formats line.
110957a5925 IViewModelLinesCollection -> IViewModelLines, SplitLinesCollection -> ViewModelLinesFromProjectedModel IdentityLinesCollection -> ViewModelLinesFromModelAsIs
f21e467f361 Moving some definitions around, mostly in splitLinesCollection.ts.
448b45ee83f Extract IModelLineProjection into modelLineProjection.ts
3ed654b8e8d handle case differences in remoteAuthority (for #136106)
d685e52b28c workbenchThemeService: Use IExtensionResourceLoaderService
0e61c493ab8 files - cleanup capabilities more
f30beef826a Replace all slashes 1a36e0b932eecd93ecbe6342be36f019672ea6a0
1a36e0b932e Fix slashes in test on windows
a553a13098c Fixes #136175 (#136176)
38cef76ce7d fix #120680.
7d46b77c311 Disable fuzzy links in md preview
fbc1f7df919 Fire event when md content is updated
003b522f3fd Fix warning log when running tests
ec2b75ac91c fix #133761.
f2cdaa0cdb0 Merge pull request #136244 from microsoft/tyriar/xtermTerminal
b4dd1f6e0b9 Fix #134214
8f672cac62d Use morphdom to reduce number of full page updates to md preview
b2494d777f4 Remove unused search process code Fix #133654
16b46aa3aaf Move unicode addon to XtermTerminal
f2150066feb Move command tracker into XtermTerminal
dc81757bf08 Add special case for webgl not working in Safari
c5e569163b3 Move cols/rows to be owned by TerminalInstance
25c2d58b200 await storing of token data (#136236)
9df7d5e3d85 Add web issues notebook
75d2e5854ed Merge remote-tracking branch 'origin/main' into tyriar/xtermTerminal
78ea0345307 Initial assignment service work (#136238)
1775f26147e use DAP 1.50
365ae1f356f Add tags for interesting browser testing packages (#136116)
2c58df8e7d5 re #135834. better logs
c51e6141741 fix #133555
73cf525905d avoid unnecessary focus editor and reveal the primary selection. fix #136012.
3af3401ca85 reduce viewCell.onDidChangeState listeners.
98dc0d75a87 restore word wrap transient state. fix #136011
a67fff8e7fb Show color widget title on load (Fixes #136224)
e56b43a7448 await storing of token data
d848f76a66b specify scopes when getting auth sessions
f8b42b4a551 Update md grammar
a9bc0553f7d Support definition links with spaces
f145c79a932 refs #134873
9571d0d469f update milestone
af8749d80e5 Minor edits
fc420cb9cb6 add custom rule to prevent test.only
a445016364d Merge pull request #136032 from microsoft/hediet/refactorings
08a9a544e1c Revert "add mocha-no-only lint rule"
cf1b304fcd4 ISplitLine -> IModelLineProjection
ba93b4cc8ef More adoption of this.getViewLineInfo.
754c262f9ca PrefixSumComputer renames, LineNumberMapper -> ConstantTimePrefixSumComputer
c95268b65d5 new Selection(...) -> Selection.fromPositions/fromRange
3583edcc0b2 fixes #136034
ee3f7eb2f5d Merge pull request #136024 from microsoft/hediet/extract-bracket-logic-from-text-model
961cf9a1856 Add trace for automatic tasks Part of microsoft/vscode-remote-release#5309
538c4932b68 add mocha-no-only lint rule
13f383439fb no test.only, fyi @bpasero
8ec8e3285f8 Add setting to specify shellArgs for the automationShell (#131099)
a80babe4e28 fix https://github.com/microsoft/vscode/issues/134656
661652b0d4d pass capabilities through constructor
a40e32caf9d fix tests
3b1290d61c4 fix https://github.com/microsoft/vscode/issues/136178
d7e50f713cc register remote fsp only when casing is known
711e68776e7 web - reload workbench when we get restored after shutting down (fix #136035)
fb4c12bfff2 Rremove async from promise executors Part of #134873
dac5e62a520 fixes #136147
309d4581e92 "Move to Next Change" and "Next Change" (fix #136059)
bf417727f55 add comment to remoteCli
3bc095ffb59 Add option: include command in screencast overlay (#126742)
c1cd6aec23e Merge pull request #136097 from microsoft/alex/ime-fixes
5b4734c27b8 Merge pull request #136210 from microsoft/joh/fix123860
13159364d97 fix https://github.com/microsoft/vscode/issues/136031
6c94f63d01d Merge pull request #135862 from microsoft/hediet/ghost-text-background-color
cbad70fe834 Merge pull request #136025 from microsoft/hediet/remove-typescript-tokenization
ad19e08c447 Merge pull request #135736 from pohzipohzi/diag
c5a2e36c89c remove old code, some polish
8c901ac05d6 update my assignments
3578230351d Merge branch 'main' into joh/fix123860
6f3f6642618 Fix #131708 (#135741)
0b686400e3c :lipstick:
15f978cd48b update areas
33b59fd8838 workspace history - introduce constant for windows jump list
9375113a83b Merge pull request #136207 from microsoft/ben/nov
6874b0315b9 editors - simplify setting editor to pane more
3761b0addec watcher :lipstick:
4e12faaeceb Fixes #135596
dabc9bdc9db Update the current milestone
f0663224101 Support auto save when delay is 0ms (fix #135635)
b525855714a watcher - implement support to restart watcher on unexpected termination
27eff83792c Properly fix #133687 (#136085)
ac04bdd298b adopt onDidChangeProperty (#135785)
6279c8cab3b Passthrough scroll/clear calls
fb5f11464aa Move find into XtermInstance
8423375a996 Add test for renderer auto detection
2d7585d9e0f Remove old experimental protocol
1fbdd010dcf Pick up TS 4.5 nightly for insiders
cbb63adc2fc Pick up new TS for building VS Code
b34c8344438 Remove duplicated language-config file
ffd414feeb1 Include `<` as surroundingPairs in JS
53ed98bb3f2 fixes #135916 (#136126)
9e096252ba3 fixes #136022 (#136054)
673165ca934 Dont override my accuracy anymore
12d38b20b17 Prefer non-builtin output renderers in notebooks (#136079)
02a191b2639 Test terminal view location change updates theme
f7cfa23249f Test terminal react to theme changes
bfe8a3e2f74 Create xterm terminal test file and first test
8cd6ff6d730 Create xterm folder
aa374c36291 Remove terminal instance service dep
e667055f4f8 Move more of TerminalInstance into XtermTerminal
a84f6fe6965 Bump distro
220d404df64 Create initial XtermTerminal class
b70ee4d5fdf Fix LineDataEventAddon register call
6172685f838 Fixes #45629: Try to align textarea's cursor with our cursor by scrolling the textarea's content
ff1e16eebb9 Fix #136009
bc4e05c0020 Add js version of setting too
d2aa181e661 add new 'includeCompletionsWithClasMemberSnippets' option (#136045)
85c3e01949c debug: fall back to explicit provided config if no selected name
bc0692cc258 Fix #135708
5e7f7589951 fixes #136021
926dcb80e1c Revert "Fixes #123592: Move extension host spawning to the shared process"
edd044c38ac add more perf marks for workbench initialization
30730efcfab Display selected kernel in kernel picker (#136042)
9fa1d5be71d Migrate docker workspace tags to configfiles (#135993)
174db5eb992 Fixes #134662: Configure strings and comments embedded in template expressions to be identified as strings and comments
b0b05ea8024 :up: `vscode-textmate@5.4.1`
5a0c4135dbb Flip default value of `__uniqueWebWorkerExtensionHostOrigin` to `true` (#134234)
1bb8780e6c9 Style terminal background correctly in aux panel
41b414c26b1 Fixes #134942: When parsing comparison expressions, try to parse the value as numbers
8b9c4361415 Removes unused typescript tokenization file.
3dbd7fa756d Moves bracket logic from text model into BracketPairsImpl (IBracketPairs).
ad6da1baa1d tests - convert more slow tests to integration tests (#135075)
fcca3787c44 :up: `native-keymap@3.0.1` (fixes #135848)
eb160fb65dc watcher - enable parcel watcher by default
d781c69d7ed sandbox - enable sandboxed file service by default
e418b6bf3e2 :up: graceful-fs
6ed67dd61eb editors - return `undefined` from `openEditor` when operation cancelled (fix #134786)
98b67faef42 watcher - do not dispose when shared process gone
061a665b9c4 update distro
bec49ce3fb5 notifications - set aria label of toasts to match as if it was focused (fix #135638)
7ca8b0f6131 Statusbar - checks if 'Go to Line' works if called from the status bar: (fix #135962)
f961b92f0fa fix comment reference
5c0e664fd3d ensure show() hide() show() hide() emits two didHide events. Fixes #135747
c0d32634fb0 Merge pull request #135805 from martinzimmermann/fix-26393
a696fa1cc88 Merge remote-tracking branch 'origin/main' into pr/martinzimmermann/135805
7d8f55ebb1b Merge pull request #135698 from thebinarysearchtree/TitleCaseAction
5baf3ab1570 Merge remote-tracking branch 'origin/main' into pr/thebinarysearchtree/135698
8eae60df6d9 Merge pull request #135197 from thebinarysearchtree/Tagged-templates
5382a52a9e7 Add a test for #61070
65a6230af9a Merge remote-tracking branch 'origin/main' into pr/thebinarysearchtree/135197
a993ada9300 Merge pull request #103738 from jeanp413:fix-feedback-widget-position
39e0f728feb typo ref #135913
f8fe350a572 Fix #135913
d578207c6c0 Merge pull request #134171 from byteit101/wrapping-fixes
bc4945ef333 Merge remote-tracking branch 'origin/main' into pr/byteit101/134171
92646227bc0 Merge pull request #119480 from codeclown/delete-duplicates
e040003822c Add more tests for LineDataEventAddon
a3bac0629fd fixes #134679
b59c8dadc44 Ceate prebuild dev job (#135924)
f191b9d9fdf Bring back webviewContentExternalBaseUrlTemplate
0e53bb6664d fixes #135970
11cd9238248 Improve LineDataEventAddon lifecycle
01fa1f6cc1b Move onLineData to an xterm addon and test
0b4f14a1784 add doc
66e3d7b9ba3 simplify range comparison
4d694341556 notebooks: fix built-in renderers not being preferred by default
fee6bbcfc50 Merge remote-tracking branch 'origin/main' into pr/codeclown/119480
1e8565d4986 Disable folding in the diff editor again (#116483)
36890f8e282 Fixes #110377 and #135023 : Maintain query and fragment parts of uris when transforming them
95bb2aaaee0 Improve TS checking in `uriTransformer.js`
4928dcd844b Keep the editor hover above by default
641467d52dc Replace `editor.hover.below` with `editor.hover.above` and have rendering below be the new default (#30797)
5b805e41413 Crashing workbench process does not bring reopen dialog on linux (fix #135950)
426f82c6816 Merge pull request #127609 from Timmmm/hover_position
b1f406fe591 Don't reuse bracket pair AST nodes that touch the edit, as brackets at the end could be extended.
e9e861fa4ea Fixes #132162 by adding \b to brackets that use letters. Uses same logic as existing bracket matching code.
eebf6387d58 Remove mixin-server task
f2c91e74bf3 Add needs-triage to endgame notebook
e4c3b3182fc Merge pull request #135869 from jakevossen5/main
27f20193dce watcher - consistent restart behaviour on errors (#135954)
8feef7f3f32 Read marker severities more efficiently
f6e8c633ff4 Don't use `getStatistics` to get errors in prelaunch task Fixes #134383
704e0d233de Fixes #135898 by adding enumDescriptions.
ee645e8403b switch to enum
3d81709d173 Remove usages of `mode` from `monaco.d.ts`
ec64531d1f9 Tunnels in shared process should be per remote (#135937)
aaa4e0a3414 Merge pull request #135914 from microsoft/digitarald/lang-rec-fix
0bc255b6926 Don't count upper case bonus if the letters are consecutive (#135930)
9eaf4c99159 force new window when reopening (fix #135906)
0f7f6e338a4 Fix #135381
50f3ca62d0d Fix placeholder for extension recommendation treatment
bc566d42a10 Try bumping webEndpointUrlTemplate again
154af5a2510 fix #119578.
912ccead657 wrong index check.
a3219878eb0 fix #133739.
ee6716d29e5 fix #134454.
2276432b714 fix #134456.
c4dcc486d38 Fix #135505: Walkthrough markdown command links are broken
9430f784850 Update markdown string docs
f781291461a Fix #134665
08409c807a3 notebook: handle duplicate mimetypes in list
99b204f64e9 notebook: fix mimetype order list corruption if resorting multiple
345c476e169 notebooks: fix mimetype display orer always saving into workspace settings
e631826588c Update Codicons:Make search icons the same weight (Fixes #135894) https://github.com/microsoft/vscode-codicons/commit/56d6bb32d87aa027576760a0337633c9bc8c4bd4
f9943ec2af2 improve theming for #134196
11d8b59217f fix #135810
7a6ffe9ce16 match activity bar positioning
ebfbd226837 Fix #135854
de8a66adaf7 debug: bump js-debug
dd1ef62ce9a Null check xterm viewport
d8b96f116d1 Standerdize captilization of "Go to"
4cedacb5ab9 Implements #134932. Allows to theme the background of ghost text.
034adf13c7a add options for jumping to next/previous problem
27ef170cb56 Fix Local Port Host setting Fixes #135201
534d68bdc45 Add repository
e0c121d5a78 Add more repositories
b9bcb742de5 change -> Change
5e4bc951cd6 Hitting return after </button> element crashes VS Code (Insiders). Fixes #135806
3e38877f5e0 Merge branch 'main' into joh/fix123860
dc1a6699060 Revert "Hardcode commit for webview endpoint in public product.json"
3d09c55e407 Merge pull request #135828 from microsoft/alex/worker-eventing
e16defc5980 Fix search editor scrolled to bottom on first search when editor group changed. (#134693)
4f5b34c1e6c change how snippet completions are computed.
4935c647808 Fixes #86481: Switching language notification only has 1 button?
a0730384ceb Change to capture groups for readability
6bfe4def013 Add support for eventing
12d9e0946ed Simplify regexp
73b509ab447 Run OSS tool
dbea36b57a4 Search editor go to location improvements (#135227)
628c6dae1a1 Over-complicated single pass
f6a5fbec58a rework logic of setting selectedItems in multi-select mode
52cd7df994e fixes #75046 - ensure selectedItems is updated onAccept
243b64d35a7 fix #135516.
c6d2e5253d3 re #134600.
af37dd91177 Merge pull request #135602 from rchiodo/dev/rchiodo/multiple_providers
42aa33ce644 Add support for invoking multiple equal scored `DocumentSemanticTokensProvider`s
11591af6fd8 Polish verified publisher styles (Refs #127825) Updated Codicons https://github.com/microsoft/vscode-codicons/commit/aeba1103adc4bc8367e58c8bba4d6ed71145a979
3ae5ecd865a debug: show warning in launch.json for disabled debuggers
31ca4cd39a0 Fix #71096
1100001c70e Hardcode commit for webview endpoint in public product.json
207fece665e Revert "Remove Jupyter specific loader special case (#126939)"
b498b7d2eaf Note in all Pseudoterminal events that open needs to be called first
21b22af19e5 Add support for invoking multiple equal scored `DocumentRangeSemanticTokensProvider`s
8e7601d3a15 change decorator fallback to ['entity.name.decorator'], ['entity.name.function']
fcdbfd08f0d fix viewport gets pushed up repeatedly when toggling size to content width #135804
b421d0159c9 notebooks: better handling of preferred mimetype
885eb8d846b Fixes #26393 by changing the default behavior of InsertCursorAbove/Below
3703c278ab2 Use `CompositeDocumentRangeSemanticTokensProvider` only when having 2 or more providers with the highest priority
a0d62edb9e5 :lipstick:
fae8d1fada4 enable opt-out of contributed profiles (#135791)
e3fbb0a6fc9 Merge pull request #135108 from microsoft/alex/update-native-keymap
e3e5feceb55 Fix typo in timelinePane.ts (#131356)
f3a14f6514a [css/html/json] update services
4d496f61bcb remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201
7fd7b8f6616 fix #134820
54ab46f0166 fix #133687
411537fdb78 bump `native-keymap@3.0.0`
c8be3bb4222 fine tune verified publisher changes
799c38a1a51 Merge remote-tracking branch 'origin/main' into alex/update-native-keymap
1466122aa83 Clean up for workspacetags (#135746)
e3ce1fe0bba fix #133741
974c28e6961 fix terminal reconnection on reload, rt of #135481
48eb908fd6a Categorize kernels in the notebook kernel picker (#135502)
f5f0b2bad44 Support ' surrounding validated links
286606327d4 Fix #135692
910511b9bd9 connect nested grids absolute offsets
2ea55a5cee6 Remove the attribute `monaco-visible-view-zone` on view zones that are in folded regions (#121516)
d5993476e1e chore: Update endgame notebooks
c208d9b0c83 Fix wording in test
51f636f90c1 #134909 queue writes and fix tests
9a3bcbe4f7d editors - cleanup wording for editors/files with unsaved changes
0e7d8a6cfd6 Add vscode-remotehub repository
2bf992d858f tests - more `runWithFakedTimers` usage (#135075)
0f7982a344d Fix mkdir arguments order (#135182)
bda864be286 Fix #134909
32744a08fb9 Fixes #135440 by allowing the preselection range to be longer than the range of the preselected item.
1c0447f9c3d backups - use fake timers in some slow tests (#135075)
d93c0197854 fixes #123165
bbf53eda82d storage - use fake timers for clear test (#135075)
3caab42e01e refine check for knowing if a view zone is visible, https://github.com/microsoft/vscode/issues/121516
c78245a79c4 Fixes #135529 by not rendering guides on top of others.
1492ce2ad07 make ResourceMap case preserving, even better fix for #128198, fyi @bpasero
208e84ae1e6 Implements #134801 by introducing editorBracketPairGuideBackground{1..6} and editorBracketPairGuideActiveBackground{1..6}.
96c0bfba4cc fix compilation
bb7c757af7c Merge pull request #133682 from justanotheranonymoususer/view-command-preserve-focus
4f9022bee32 fix #88927
e37c9966e92 Add vscode-livereview repo
803d2b5db9f fix telemetry event
e7647291206 prevent unneeded re-render of breadcrumbs items
ba5517b9115 Fixes #135151 by not colorizing brackets or rendering line scopes in xml.
ad36148dd2d correct doc for `count` property of `SourceControl` (#117765) (#132242)
e922713ecf8 Fixes #135726 by properly skipping unbalanced bracket pairs when rendering bracket pair guides.
f1343b2aa03 debt - do not use `| null` in editor service API
fc6b0cc71ba themes - improve window border color
14c1d73e9ec Simplify regexp
0dfb0322e6c Minor fix
a3192fbad7b Merge branch 'master' into fix-feedback-widget-position
45fdad3a10d Fix #127825
c42ab56a65d Don't register twice
e78e63fc3af Window crash: "Reopen" does not work on macOS (fix #135572)
2d46dec27ae Handle apostrophes in TitleCaseAction
b3d14424775 bump distro
0cab2d58d35 Adds support for separate horizontal and vertical borders for side by side editor (#135181)
e29d3cca5ad WSL1: Use parcel watcher for polling watch mode (fix #135691)
6c0929c8c4e cli: treat /dev/null as non-existing file (#135645)
5e10a96239e Revert "fix extension pty terminal test failures (#135672)" (#135685)
af0c0342ede fix extension pty terminal test failures (#135672)
870aa86258c Fix css rules (#90022)
63cf9b852bd Fix #83025
24af01a3a47 notebooks: better memorization of preferred renderers
baa380d17be testing: adopt optional value standard
2ada30a9ece Fixes #134973: Cast to uint32 before validating that semantic tokens do not overlap
af1c6c08dd8 fix #135649
ce049678aab Revert "migrate process properties to use generic onDidChangeProperty  (#135610)"
dae4136057c Revert "move listeners outside of onProcessReady block"
7d3413a9de5 Revert "emit Exit via propertyChanged"
e7b40c1217e fix #121897.
1608901ff51 Don't scroll terminal to top when hidden and shown
dda4f430d0e fix #135523
9bca7ceb057 emit Exit via propertyChanged
c264147c685 xterm@4.15.0-beta.10
a2a1c4baa4b Merge pull request #135081 from AiverReaver/minimapScrollFix
aa5b9d7e11e Fixes #135102: Apply editor font info for code blocks in hover
50404fe366f move listeners outside of onProcessReady block
86fe048df9e migrate process properties to use generic onDidChangeProperty  (#135610)
47c02a81278 Fixes #128131: Also consider `%` in monospace check
cf6f88fe9ac Update default color for cell editor bg (Fixes #133699)
9f8d800008c fixes #128695
31662e1ed94 Make sure to cache result id and use the appropriate legend
778d70441dc refs #126614
f21c1a33e59 make checked optional on IAction (#135605)
d209aa2b02f Rename `modeId` -> `languageId`
621f3bcc0b6 Tidy up call into pty service
b377ec20d64 Tweak access modifiers
031b2803cf2 Merge pull request #134861 from luluyuzhi/main
5208c6a3b6a #134089 Fix compilation
b6aa001ed1c Merge pull request #132027 from brajkowski/issue-129911
d81d3ce59c8 Add tests for $ in validated links
4808fea006a Fix #134089
c0c82e04ea4 debt - use | undefined (#124362)
8fbf9b600d5 debt - use product service in more places (#135651)
5446f5e01ee Merge remote-tracking branch 'origin/main' into pr/brajkowski/132027
fac06c7af7b Update distro
7f754c8a03d Fixes #94313: reveal position, not line
7ca1f2cce8d clarify doc, fixes https://github.com/microsoft/vscode/issues/126748
dc811974e50 better document what default excludes are not, https://github.com/microsoft/vscode/issues/48674
a30ea744d07 Improve logging
3747b7d5f91 Make the editor hover explaining tokenization problems aware of the current language (#135573)
8358d0ca67b Define 2500 chars max limit for javascript, not typescript (#135573)
af09288b840 Tweaks for #124362
7743406f2c0 use editor default font fallback, fixes https://github.com/microsoft/vscode-dev/issues/425
ae8175ebfe0 Fix #25290
4aa85e030ed better fix for #135634
60057f97131 [remote cli] difftool on newly created files cancels the diff and completely closes the workspace. Fixes #135634
e2e6a28449f sandbox - share the same server side file system provider between main process and server
82a02e63b7e sandbox - enable sandboxed fs provider by default (unless stable)
bcb9df5afa5 fix hasSession by using silent: true
1eb38d79bb9 Update root container when panel is moved
d46933ce871 Build using typescript@next
21e5f0c8ab4 Add "NotebookCellExecutePrimary" menu, towards #132057
a1bc3f5776b Merge pull request #135444 from j824h/j824h/issue135264
ae6066d6769 Double check called both providers
eef5a74688e Add test for multiple providers
1e750a7514f fixes #114329
5a6943c21bb fix #133680
61eca00b0cf testing: fix default click action=debug not working
e8662249069 Register onLineFeed only after initialText is written
c416a017862 fix #135585
6a1293526fc fix no profiles showing up when useWslProfiles is false (#135498)
e9d68a1e675 Put back old method for use in viewportSemanticTokens
7b32ae1182e fix #114768
6da697ce413 Cache last provider for range token provider too
3daf66b813b Cache last used provider for legends call
02b52091cce Build problem
37f5d53a7d4 Add keybinding table tokens (#135018)
9e7ea088043 fix #135476
6a367e8ce41 editor: give default link provider access to all models
5f161f21622 Multiplex providers into one
6c7b2b34069 #135075 Use fake timers
26cf9202220 don't assume command make a textual editor (at the completion itself), https://github.com/microsoft/vscode/issues/120070
5b7208ac084 Add -g flag for the open command (#135517)
724d8f64079 Fixes #93769: Respect `zIndex` when rendering decorations in the overview ruler
09a55c7bed5 Combine the implementations for `getAllOverviewRulerDecorations`
7443621e3b4 Fixes #66482: Stop massaging marker ranges since we now render squiggles with empty ranges
91c9d8ba86e Fixes #135467: update to latest loader which honours `nodeModulesMap` and `amdModulesPattern` only when running in a node-like environment
7fefb2f9422 [html] auto-indent not working for tags with attribute values containing /. Fixes #111932
80efd13db40 fix #135558
3685f3da9e9 fix #135557
d7dce57ab47 update distro
42a0825e8ee Allow building to continue despite a missing `remote/LICENSE` file
c3488ed740b Request adding new 'decorator' semantic token scopes for Javascript/Typescript. Fixes #114082
c2f44d476b4 Merge pull request #135484 from adaex/update-seti-ui
865593aaa36 Don't render bracket pair guides for unbalanced pairs. Fixes #135549.
72b0b1c17f2 fs - use `onUnexpectedError` to prevent logging cancelled errors
aaf74285ae9 fix tests
cd9da9425f8 Add web kind only in web
97018d742e4 fix windows build
0c402a1db36 files - align names of IPC backed fs providers
1770223d16d Error: disposed around DiskFileSystemProvider.doRefreshRecursiveWatchers (fix #135530)
46b2246ca6a update distro
5f226a990ce Remove special rules for `src/vs/server`
845e410a525 Define a server greeting via `product.json`
9d67be7ae06 Remove no longer necessary special settings for `src/vs/server`
a9438c996cb sandbox - restore session based file watching (#132282)
4cfa84488d6 editors - update settings description (fix #135185)
d5ecf7e9d88 fs - some :lipstick: and enabling of `graceful-fs` centrally
e8f55fba4d9 fix #111723.
3d0edfc790c fix #79969.
3a5ac4951c1 Merge pull request #134241 from suzmue/disass
ec6ee19e3cb Fix restoring of focus when webview content updates
df62644ea63 Integrate Source Code into Disassembly View (#132541)
6e5b1726a4f Try fixing some focus issues with webviews
85edd692486 fix #111724.
b97ab80c188 Fix typo in PAT auth flow error message
f8830172060 debug: make serverReadyAction multi-session aware
17dc0268248 Fix a few more cases of math block highlighting
3eeb80e04e2 Remote file not opened in existing remote window. Fixes #131731
c38d441d371 Make sure inline math is marked as markdown-math
3dc7b03ff99 Allow leading and trailing math on same line as math block
f5ca93d0fac debug: deemphasize internal variables too
989bb81f9fc debug: prevent double clicking to edit readonly variables
b34a52ec66a testing: nominally request links in test peeks
d51d2910d89 Fix scheme check
04f51add618 Disable markdown math inside of raw code blocks
91d2bdded21 Silently fail when remote environment isn't available
570f82fa66a Confirm when using tab inline kill action
514ad0acf04 Fix #135422
c71e201bed8 refactored mainthreadauth with silent option and tests (#135503)
fb0e4870b34 fix  #135424
55c8ba91fa9 part of #134907
e11330935d2 fix #133968
d0c2b01b60b fix #134596 (#135495)
510b49e1da0 New snippets file has language mode of "JSON" rather than "JSON with comments". Fixes #120190. Fixes #119538
634b99eed59 show better messages for windows error codes (#135483)
beb95ba6a96 update distro
4cd2b53b312 Remove unnecessary scripts
822f995357f Add server folder
fc504f3af3a Fix when clauses for Emmet commands
56deb2ac17b Update to latest seti-ui icon theme
8bb5c7ae07b update distro
0fc4a488a8b Improve handshake
5f0cce54653 watcher - diagnose flaky test
96ff0e06668 "Workspace does not exist" when failing to connect to ssh remote (fix #135331)
792df9da2fb Fixes #135125 by not colorizing any bracket pairs in html.
2e112c714ec sandbox - enable `graceful-fs` in main process too (#132282)
2f574828e5b sandbox - more reuse of sandboxed fs provider (#132282)
1b8fd2edab4 add skipped test for https://github.com/microsoft/vscode/issues/112362
c8c5f5b0838 Update the tracked repos
de2f16bde7b trigger quick suggest also when composition ends, fixes https://github.com/microsoft/vscode/issues/123672
d40fe68ae02 fix https://github.com/microsoft/vscode/issues/131700
3eead37a434 Handle async errors (#134873)
2f795d34eec sandbox - implement non-recursive watch support (#132282)
ac8aed60e75 Enable replacePattern
2ae9352ae33 Try to avoid opening text documents just to  process diagnostics
8fc2a8d2ce1 Fix comment
f58cc479831 Remove redundant comment
d0d4a33707a Take out nowrap rule in Settings editor
0047e023721 fix #131706.
f6de5208d8e fix #126475
286370b3472 fix #122563.
7f8d4650698 Fixes #134149
aea6270bf81 fix #120680
f94ce8b3845 fix #128329
945b0fde6c5 re #127177
f37df8f5079 fix #130239.
98f31a44abc Bump distro
89c7f3b2640 fix #135340
156a951b64b Dispose of language status items on dispose
c72b5c4adad intercept and improve terminal launch error message  (#135420)
a535b04e04d enable terminal actions for web and when a terminal has been created (#135423)
0db19c10d6d Updating the TerminalInstance to only reigster link providers once. (#135419)
550ae45dedf Fixes #121160: Tokenize only visible model lines
242a6c3e102 Fix default value comparison function
8f1de4ef9af Add left/right quotes as terminal word separators
6f385bee78b Don't try to hide untracked views in filter view
985090f51cd Fix #135379
569e06a834d Fix #135381
d49212e2d65 Update commands.json (#135319)
856e6a81ae5 Fix #135395
3a19a2f22ca Refactors bracket pair colorization feature.
049691cf79f Fix env passing with open cmd (#135039)
b21fcd3aa4e Expose `onDidChangeHiddenAreas` event (for #121516)
0e48dd9af2f send telemetry when keytar shim is handed out to extensions, https://github.com/microsoft/vscode/issues/115215
1b364332c46 Use null coalescing instead of ||
cdfee234401 Rename KeyCode enum members to more closely resemble ScanCode enum members
36e0bf5a99b Add more media keys (fixes #47115)
b032d98a9ab Explicit values are no longer necessary with const enums
f1291d04562 Make parameter hint highlight themable (Fixes #92297)
6a9bd76b69f fix https://github.com/microsoft/vscode/issues/135326
d8e92cac361 Fix appHost being improperly defined
4ae42ccd2e6 fix suggest widget details min width
2e62d3decb0 debt - deprecate direct use of `product`
fba6ce545e5 Add colorized bracket highlighting colours (#132494)
19dca64e388 pass the correct cancellation token to working copy participants, https://github.com/microsoft/vscode/issues/135036
95fe3ec83d2 early exit when working copy handlers have empty results, https://github.com/microsoft/vscode/issues/135036
8434e32b5c5 remove unnecessary dot from 'welcomePage.tileShadow
32666ede944 sandbox - first cut file service implemented by main process (#132282)
41f79ee0e98 fix distro build vmImage
65f84540897 Merge pull request #135369 from microsoft/alex/extra-keybindings
bd6e614cda2 shared process - use a different event to dispose worker when loading/reloading
1ae2d2ce9fc Group various key code related maps in one table
7dfe2e33eac Fix test running around loading `assertCleanState`
4478ce868d3 shared process - use correct hash function for config
75c6ab839f2 when pinning language status prefer its command tooltip over its detail, https://github.com/microsoft/vscode/issues/129037
ba5e8ed094c scm: bring back focus restore
d817eda05fc Properly fix #134053 (#135347)
8a4ed7f5560 fixes #95994
28c4e210a73 fixes #123953
8dcaf1af6ad fixes  #134017
7bc28074bf4 Exclude tr from markdown hover
92cb2aee036 fixes #93837
a200c713f6c addresses #99054
18f64c76f9a Fix #135163
22d67b5fca8 fix #134623
699bb8768e6 Move event key code map to `keyCodes.ts`
32b6b2e968f Add terminal keybindings for NUL, RS, US
2cad3bfe872 Move VK_ to KeyCode map to `keyCodes.ts`
b2df38cce15 Improve profile setting description
102c4628acd Move `ScanCode` to `keyCodes.ts`
1a7750c744f Extract keybindings related types to `vs/base/common/keybindings`
36eda057932 Add more media key codes
4f1c8af729c fixes #135302
db4a791617e Changing port "privacy" to "visibility" to address Codespaces user confusion (#135193)
438c92c106c Fixes #28576: Add support for `BrowserBack` and `BrowserForward`
32c20e923d4 fix: the quick diff should respect `diffEditor.ignoreTrimWhitespace` (#135285)
d1640f2aa8a shared process - :lipstick:
53e1748c1a8 fixes #134792
b53c8e1d999 Merge pull request #135188 from JaredNeil/jaredneil-fix-bazel-icon
469d4f6a1c1 Merge pull request #135272 from microsoft/alex/language-identifier
59791a74dd1 shared process worker - document affinity
8c05769b979 :smooth: shared process worker dispose
259878f1daa Merge remote-tracking branch 'origin/main' into alex/language-identifier
11862795ea2 Remove `LanguageIdentifier` and ensure tests dispose instantiated `LanguagesRegistry` objects
12ab43e896f fix spelling issues
7f88203009f shared process - fix worker dispose
94ff6a1900c shared process - rename service folder
5f066b73ded sandbox - lift file watcher interfaces to common
54a935e5676 shared process worker - more lifecycle tweaks
729d8162381 sandbox - implement affinity and lifecycle for shared process workers (#132282)
1bfac7ce8b9 watcher - properly await unsubscribe (#135069) (#135209)
74541dceec8 update distro
fb659f1542c Add `IOptimizeTaskOpts.externalLoaderInfo`
aacd8438ca6 fixes #112541
e19b98362b1 Remove backticks from word character fix
96cda0bb6bd fixes #122902
a84e1931aad fixes #122902
ba15c2dac75 Properly update tree collapse all enablement Fixes #134762
da0d9c481c3 reduce indicator and apply to auxBarPart
d69f7aa70f9 Fixes #125437 (#125438)
a0cd34caf45 Fixes #134177: unset `LD_PRELOAD` on Linux and consolidate code
c0001d7becf Fixes #116483: Allow folding in the diff editor
8d542f91be4 Color picker polish (Fixes #83589)
5240d97cf3e Iocn hovers stopped working. Fixes #134794.
a80c2a58c35 Menu bar step in web walkthrough
a946f9e643d fix for #134873
e02350dd74c Fixes #131277: Reveal entire diff range in center
a12e9cd91ed Fix zoom-out on an image [#131080] (#134706)
38a711024d3 Merge pull request #135184 from rchiodo/dev/rchiodo/add_notebook_triage_labels
b85a2722984 Fix csp for CDN extension locations
65f21ad59fd Update seti-ui for Bazel icon fix
fa1e1fa7016 Fixes #112614: Improve key code => scan code mappings for Chinese keyboard layout
9a958ed0226 Add test for zh_hant2 (#112614)
bbf6e5ccbfb fix #133459
0d1d04a59eb fix #134053
3208d53cb19 Add triage label when notebook label is assigned
f2c43358fa7 Fixes #130396: Allow extensions to contribute keybindings using scan codes
94503ddb369 `let` -> `const`
4106bf9447d add distro bump for @sana-ajani
3307011b91c Revert "update distro"
709c6058997 update distro
8add766eb27 use dom API directly so that the url is encoded properly
8d0fd2aff65 ext: pass cwd through when creating extension host
a78567110cd html: polish reading of settings
8d70e049dd1 Merge pull request #129284 from ssigwart/noQuotes
b1c3c969012 Merge pull request #135050 from sean-mcmanus/patch-1
5e2605f0e38 Bump emmet-helper
d2264e3e0ad tree: fix visibility not being updated on refilter
a73b1deae10 product => productService
8440cbc58cf Scroll to the top earlier after search
5350eaa2059 skip failing test
3772b59e82f Bump distro
d33c0621bc0 don't escape dot as syntax token, fixes https://github.com/microsoft/vscode/issues/127097
6d89ada05d6 web - allow registered commands to appear in F1
fb4d7cfb622 ci: update sdl-scan exports
fbbb4d7515b chore: remove redundant build_from_source env
c132e4e19bd worker process :lipstick:
075a49a646c fix https://github.com/microsoft/vscode/issues/130838
f031c70ac47 watcher - skip test that seems to crash build (#135069)
1afe238fed4 comment out failing test (#135157)
d0f1a896825 debt - set `build_from_source` to match our CI (#135100)
1ba2b2a952a remove stale label
01a569b74f1 watcher - rename type
9d8eab65090 fix https://github.com/microsoft/vscode/issues/118049
d4b84dc83fc fix https://github.com/microsoft/vscode/issues/125194
be58a3560e6 First cut experimental setting to run file watchers from shared process worker (#132282)
7c61ce575f9 Merge pull request #135089 from microsoft/hediet/cut-last-line-mulitcursor
34eeebdd660 Add embedderIdentifier as a context key
e125508f86c Update colorization test results
bc76074ada6 Revert "Improve logging"
33d6815ac38 Fix potential null ref
011b20c468f webviews: add extension id to webview views url
1eaf52cfd50 Support theme-icons inside other markdown elements
41df0673f81 Allow spaces in katex commands
03ce3074442 Add transparent overlay while dragging
1ddaeae9bed Align view margins (Fixes #93023)
b6a2e697b85 search: fix inconsistent regexes with quantified negated char classes
5f235f19281 Update Codicons (Refs #54275) https://github.com/microsoft/vscode-codicons/commit/4d7a083443f3122a17c08f8363731fc1ec356509
d7d69ce904f Fixes #135101: Install named pipe listener before launching the extension host
4bba4f2554a Improve logging
25b9d7dc82f fixes #130484
684fff706a0 initial unoptimized hasSession API
9e944616606 hide terminal dropdown if no web extensions contribute a profile (#135115)
328ff61748f Given web steps unique id's
373e8809c29 Respect whens on open first
dcfd72e8447 Split getting started into web/non-web
bb5ece1678a Allow telemetry footer to open on main page via prodict config
e35e898ac77 Fix ext host performance metrtic classification
ff6c1b51a88 add web label to web issue reporter
7da76ad0611 Update to latest `native-keymap`
53cdb03a854 Revert "Update to latest `native-keymap`"
4150347750b debug: activate debugger post-resolution if its type differs
f17b1ec6386 more web friendly keybindings for New Window and New File commands
e14c37c3b08 fix compile error for unused type
a9a7c16b38a just check if clear is defined
35cd6e91488 add extra data for web issue reporter
9bb86e9f534 Speed up createFile unit test ref #135075
6ae9e9d86cb Add more specific check for lib files on web
787554d2516 improve watermark further
92c2c396df3 Update Codicons: Update `whole-word` (Fixes #54275) https://github.com/microsoft/vscode-codicons/commit/bde6c41dadd11fcba8d2ac0440d0eca32a058be8?short_path=ebf01af#diff-ebf01af4e09e7b58fa1c8e3ee1d6c7815cde60ff290c651bb56bddbe700234bd
29d0c902a61 Include extension cdn in webview.cspSource
b7c340f119e Simplify import path
15394cbf747 Update to latest `native-keymap`
c5867689283 Add a test for #128602
2e0bb644614 Adopt latest loader
4cc9d87390a Fixes #128602 by adjusting the line when the previous line is also cut.
073a3d97484 Don't allow context menu when no terminals exist
eb4f9085775 watcher - increase timeout to reduce crash likelyhood
55524bee8a9 fixed minimap slider width when page is scroll horizontally.
f1f645f4ccb editor.guides.bracketPairs: 'active' | 'all' | 'none' -> boolean | 'active'
78d226268b0 make `nonce` transferable
8058194c2ab sandbox - requestChannel is optional
4e31ae70e14 :lipstick:
46e8f2054fb sandbox - make acquiring message port from sandbox reusable
067261c03ba sandbox - make shared process service available on startup
cad4c193d85 Have web issue reporter be a little more useful
c986aef642f Remove .only and fix fragment used when opening file
830987eac30 Refactor document link opening
d1f72b54206 Try to clairify how md links are resolved
46996ba8644 Scroll the tree to the top after search
7548d58ac6f fix strings
ae1bfc57d17 Update package.json
20e692d1d3b Add icon for deprecated messages in the settings ui (#135044)
2aa340816f3 Pass process.env using env flags
809becc58e8 Update telemetry text
497e90cf9a0 Reduce timeouts in tests
77949c2bc0d Update distro
728f8130186 windows-process-tree@0.3.2
c7906b82e93 Fix settings tabs widget alignment
6a95fb2ec2b Add focusOnlyEnabledItems to settingsSwitcherBar
1f660df97e3 Fixes #23690: Update `native-keymap` to a version that supports detecting keyboard layout changes on X11
3cce1d2c251 Clearer Settings UI for new telemetry setting (#135028)
6e0f56f0a92 build schedule
21560e806a3 web api: IExternalURLOpener
bff0b7805e6 add new embed API for clearing credentials
b4ef4895395 Update Codicons Remove pinned-dirty-small and pinned-small https://github.com/microsoft/vscode-codicons/commit/1a9d49e68dedc934f40cc127357ce92d977bc7ae Refs #133422
26dd05c6833 Add "engineering" label to area label query
4dfb9198f93 Move search tests that spawn processes to be integration tests #134972
a4a3e4e8b0f remove async executor of Promise ref #134873
ea3a0e5d870 #134972 make tests faster
4b75543b26b Update my work notebook repos
11747d518f7 move file watcher tests to integration (#134972)
fe6fc13df36 debt - no implicit any maps
498d7861564 Specific the Map generics in history.ts explicitly (#134896)
d70ffda082b use small lock icon (#133422)
1a2749d7988 Fixes #132802 by making maxTokenizationLineLength configurable per language and reducing the default for TypeScript.
077c5749d2f move ipc.cp tests to the integration suite
ad9e3006ea3 fix https://github.com/microsoft/vscode/issues/134846
cac7d5580a9 Fix #30165
0752ca0ecb1 force change MODEL_SYNC_LIMIT to low limit when testing ignore model too large for sync, https://github.com/microsoft/vscode/issues/134972
fd4311b68b0 Fixes #134690. Don't compute ghost text if preview is disabled or if the suggestion is too large.
cca2d71a825 restore previous runtime behaviour, https://github.com/microsoft/vscode/issues/134979, https://github.com/microsoft/vscode/issues/134892
01a10db5504 remove cron
532f25c4ac5 add debug logs
e38409bff39 consider only true value for donotSync option
d0cdfb9a2d2 Merge pull request #134890 from microsoft/alex/electron-accelerators
793dc938900 Update extensions-web.svg
6b6ab541884 Fix #130384
8b2b819f55a Update test case
83fec0220ce Add retry logic for flaky git operations Fix #132218
3bf7202085e add context keys to watermark commands
5d60bcd2414 Fix null type error
d96ced4f2f3 Decode fragment on links when looking up target
50e08d1f790 Use query selector to get base
a6a8882627a Update getting started extensions for web
d3ceb35bece Add source map for every possible element in the Markdown preview (#134799)
d8f67118b4e Fix #https://github.com/microsoft/vscode/issues/134667
779360bdd62 Remove `electronAcceleratorMap` since it only contains 4 special cases
7f585516c18 Fix https://github.com/microsoft/vscode-dev/issues/246
344f2ba2aef Do not pass OEM keys to Electron on Linux when having a non US Standard keyboard layout (#23706)
6e701c847ec Add more logging to capture case when the menu asks to dispatch a keybinding
cee08d43d09 Avoid async promise executor #134873
b7ce2ed34a8 Merge remote-tracking branch 'origin/main' into alex/electron-accelerators
04dc16251a4 Fix compilation errors
3e905978d94 Merge remote-tracking branch 'origin/main' into alex/electron-accelerators
caa8e81102b Fixes #24166: update node-native-keymap, which now respects the current effective group index when getting key map
0845d582348 set default value of process revive to onExit
38a2659e4ca Reference codicon duplicates
41dee5fd91a Update Codicons Add `lock-small`, `pinned-small`, `pinned-dirty-small`, and `azure-devops` Fixes #133422
03cc7e9ddb3 Finalize MarkdownString.supportHtml
fc7a9d13098 Add missing change
757da367d3a Clean up types for Tab public api
d8091da23cc Simplify _onDidChangeInlayHints firing
f74ad40a3e9 Adopt #134873
3c1f4c5ff4a fix #134837
a3843b395ff add localization to execution count label
79a3586d6c0 Add cell_ids for ipynb with nbformat >= 4.5 (#134835)
f3912530443 Switch settings-editor assignee
a2b4f09c6ab have web issue reporter use same service as desktop one
78b36549b88 support donot sync option for extension installation command
822d968b952 update distro
7fcd5bb0946 fix
8b1f10af35e more web changes
d89101fcaab Merge pull request #134856 from yume-chan/patch-1
e6443351fe3 Give hints for navigation mode in terminal textarea aria label
af376e98a82 Remove async promise executors
b2679a79bd9 update vso allowed extensions
bb7d9597f5d Remove async promise usage in externalTerminalService
f1449c4cdc3 Fixes #134664 by committing inline suggestions on tab when the indentation of the inline suggestion is less than tab width.
94ec6e1bc5e Remove workaround for #101754
205a89c5234 Remove workaround for #108880
4c0fdeab279 Non US keyboard layouts: pass OEM keys as electron accelerators
04bb52865ac fix https://github.com/microsoft/vscode/issues/134892
62046733313 Merge pull request #134840 from timretout/debian-package-debsums
43e75af5b5c limit feature-area labels to vscode-repo
ea91d365aa9 Move Electron duplicate modifier check to `BaseResolvedKeybinding`
8505cd7eacf Clarify that why we cannot pass numpad keys to Electron
31da37a9278 Consolidate key code to electron label map
d9a1373f5cf migrate editor.guides.bracketPairs: boolean -> : 'all' | 'active' | 'none'
bdc59aac50a Remove async promise executors (#134873)
5441393b4b4 Merge pull request #134781 from microsoft/hediet/bracket-guides-indentation
5e7307d42a0 Merge pull request #134259 from microsoft/hediet/horizontal-guides
7283f5cb7c0 fix https://github.com/microsoft/vscode/issues/130057
6f4994e6bb8 fix https://github.com/microsoft/vscode/issues/130910
98a4760a40b Makes bracket pair guides aware of indentation. Implements #134267.
b028a017068 no async promise executor, https://github.com/microsoft/vscode/issues/134873
3c1274461db fixes #134638
4e7516f9e14 Implements horizontal guides for bracket guides.
3b1df9338f0 Merge pull request #134503 from microsoft/hediet/configurable-bracket-pairs
4ae02bda9be adopt #134873
0a147eb40d8 Uses proper language configuration service for bulk edit.
3cda269c800 ESlint: enable no-async-promise-executor (#134873)
0d803d3e51a Fixes #123592: Move extension host spawning to the shared process
aa5a6405d2d Fixes test.
d879e6a8a62 Test Failure: Recursive Watcher (parcel) (fix #134865)
1e4cdf61d8a API NB, set milestone to October
a1bf964306d Terminal editors are always marked dirty.
9549c24662e Merge pull request #134810 from microsoft/alex/stricter-webpack
284e0db6c4c fix build
c6e447b350e Fix a typo in npm extension package.json
8b688986b7c Enable rendering of bare math blocks in notebooks
9e548239ea2 Adding two more area labels
29cc85b3167 testing: fix duplicate run progress
5cc120e08d6 testing: adopt queueMicrotask
68013971ff8 Add language mapping as param to getEmmetMode
9176be11bc1 debug: don't active js-debug unnecessarily
2a656c86053 Fix https://github.com/microsoft/vscode-dev/issues/338
3914b9bda5a Update desktop file cache in Debian package postinst
0bd3cad8cf8 fix #134817
f47ae9e324c Disable dynamic routing when experimental project wide diagnostics are enabled
abee3e885c1 Further address #134660
b0c930bdbb8 fix #134828
d4d78b65538 Ignore detach process calls when they're not supported
ab66c85e0d4 fix #128049.
f8679c1e68c Auto detect color scheme not working after reload window. Fixes #126823
6cdd3842839 Updating peek title info color (#134821)
cda6f05c6c8 better height calculation on diff editor creation
898c759f85c Fail the build when webpack has bundling warnings (early prevention of issues like microsoft/monaco-editor#2691)
84a5899485e Darken banner background on light themes
2f3a3c11835 web - remove "Download" from F1
93f59447d12 merge `arrays#distinctES6` and `distinct` and avoid O(n2) perf in most cases
a390f81744a no hack is better hack
c15218d09e7 use biased extUri when feeding data into extensions tst, https://github.com/microsoft/vscode/issues/134602
e37ede4054b fix typo
5b0b68b000b Merge branch 'main' into hediet/configurable-bracket-pairs
665020137a9 Incorporates feedback from PR.
1753fed7105 Fix #134792
91a9d7bb1d3 mark expensive distinct for deprecation
2e4d7db64d2 Address #134660
a6eb6304007 collapse editor selection right before applying rename editor, fixes https://github.com/microsoft/vscode/issues/131357
7d441890e2d bump version
bb3834ddf31 Fixes microsoft/monaco-editor#2691: add explicit exports in ESM for DOMPurify
e652e8cf222 remove obsolete notebook
8db8a07b4e1 use true casing rules when creating extensions tst, #134602
b8ec99894e1 #132192 add some trace statements
6759fe1c8c6 show limited support as warning
8d7bb23720b watcher - understand more patterns as full excludes
690de80fbd3 fix MD formatting
0d5d05331e9 add query for issue without area label
0debadce727 shell env - reject with error not string
897ed300e68 Support terminal.integrated.cwd as a resource scope setting
a9bcd45ef32 Merge pull request #134752 from jeanp413/fix-134750
6c302fbb07d storage - handle missing object store gracefully
d03d1d044d8 Reduce likelihood of forgetting `LanguageConfiguration` members in various places
12e9847a934 watcher - fix tests
be2f951fde6 debt - introduce `Promises.withAsyncBody` and adopt in a few places
a9fe46517ec watcher - fix tests
ef1fc4b843e Merge pull request #134387 from rjc/patch-1
35d7a3133e0 fix #134595
112a32e6145 Add another limit to when we auto-dispose document references that have been created by extensions. In addition to a timeout and overall weight, we also check the number of document references we have and cap them to 60, fixes https://github.com/microsoft/vscode/issues/133325
547d92631e9 getExtensionPathIndex indexes extensions by URI, not just fsPath, fixes https://github.com/microsoft/vscode/issues/134602
360139292c5 watcher - delete our windows c# watcher
c3f78fcbab3 :up: distro
85c5eb7281c Enable `parcel-watcher` as new default watcher (#132483)
5dcc08052cc change back onDidChaonDidChangeInlayHints, ignore events for model for which a request is currently pending, https://github.com/microsoft/vscode/issues/13043
e96a97448aa Fix location comparison (#134755)
1ef119a0cc6 Fixes #134750
be75065e817 fixes #134147
7672ab4e281 testing: allow updating expand state of existing items
c33e050927d tree: allow changes of existing diff IDs to trigger rerenders
d92cbfca787 testing: fix terminals not being reused correctly
44de6e9b975 testing: fix multiple overlapping messages per line
0f9d3f4b634 testing: fix letter spacing in test decorations
2aadb612380 Fix #131599
8919d390ebb Fix #130868
b1a1f7f21af Close #133785
6481ffa1c7d :lipstick:
bc43967e220 avoid flash on output expand/collapse.
529c957874a Add more aria labels to Settings editor
845af8a5c3a  Enlarge small markdown text size - trivial change (#134550)
14f72608c00 Remove definition list snippet
649a1afa53f testing: run all tests with equivalent range at cursor
30e17436c53 fixes #134196
5364c567683 include insiders.vscode in nocors
39f00c53803 Merge pull request #134586 from microsoft/connor4312/remote-ext-host-env
bf997b6aa56 fixup! missing bits
21991a02a0c Merge branch 'joh/tstavl' into main
9eb85d54215 Don't fire telemetry change event if no change
deb4ed92426 scripts/test-documentation.sh fails: Can only register one file editor input factory. Fixes #128155
858c7ffce14 Merge branch 'main' into joh/tstavl
031e699f37c TST rebalances on insert and delete
1fff41e37c2 Use actual value
91de5813229 fix spelling of isAuthenticaionProviderExtension
62482f6ced6 'Reload with extensions' disables current remote resolver. Fixes #128227
3860b772e4a Revert "Simplify external .d.ts"
258f6783233 update grooming queries
d9ae3f7992b Merge pull request #134646 from microsoft/sandy018/bisect/enabledExtensions
29ce7334155 do not disable always enabled extensions
b700cb689a6 nit bit
14dae5177e0 show limited support message
7aaa2474eb4 JSON Schema validation https failed without details. Fixes #127769
d7ec4b3edc8 remove unused parameter
435f287a5c1 Remove support for `@monacodtsreplace` since TS has gotten a lot better at emitting dts
0eaaf654c8b check in compiled file
1f9771c1047 update distro
cae4478f04e enable proposed api flag
4395e202062 enable proposed api for vscode.typescript-language-features
a75121a74c8 Update ThirdPartyNotices.txt
7af515f290f Set `define.amd` to true
35a8182683e Fixes microsoft/monaco-editor#2671: Make marked.js ESM compliant
65b10df98f1 Simplify external .d.ts
0dae77d06e3 Enable markdown links with line numbers to non-md files
ecae847b95e Fix navigate in untitled files
d8507236f11 Rewrite logic for opening markdown document links
710e0d4d9ce Add mjs/cjs and mts/cts to path based language mode checks
001c14610e3 Don't collapse whitespace of code blocks inside suggest details
a3b9691e13f Use relative line height in hover/suggest/param hints widgets
39f299abb11 fix #134059.
62d631a165f Add serializer for simple browser
f542a0e83ab Update emmet-helper dependency
c359130500a Change emmet.extensionsPath to machine-overridable
24a4fe72450 refs #110083
3629e682509 Fix rendering of `@example` comment blocks (#132821)
6b1e7a71157 re microsoft/vscode-dev#285
456296f36d2 testing: better support controllers who don't parse unsaved files
c867ac72915 Add an a for consistency
2b06d315be4 Fix link in .d.ts
492f07122ae Update version
f92df8b8d0b Status hover: cannot show hover twice via keyboard. Fixes #134091
6f47f12c4d3 Include polish as a issue type
bdbe7d09952  #134595 minimal fix
d130a278c6c debug: apply environment to remote extension host
f25fd50e229 Add > to Emmet expand suggestions
8ae69c7a39b Use insiders bits when running tests
5f168021c4c clarify how Memento#update can be used to remove values, https://github.com/microsoft/vscode/issues/134424
fd01f5f659b don't wrap link text, https://github.com/microsoft/vscode/issues/134554
760c1787029 Fix #134568
d5248f31678 Revert "Add model change events separate from group"
df994efca55 Fixes tests.
3543f9386e4 web - tweak wording
c1f128639b0 Codespaces: better handle invalid workspaces when opening (fix #133872)
262cc6e4e70 Add tooltip for keybinding (#133655) (#134438)
619731caec0 web - fix wording of open dialog
4f518df006f Fix link
cb369b4b4ed Put s inside the `@link`
91132cab87b Use `| undefined` instead of `?` for some readonly properties on objects that we control
2470310ad24 Assign Peng on notebook.* issues
665e0adaec2 Add update …
@jrieken jrieken removed their assignment Nov 22, 2021
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Dec 15, 2021
jrieken added a commit that referenced this issue Feb 11, 2022
@jrieken jrieken self-assigned this Feb 11, 2022
@jrieken
Copy link
Member Author

jrieken commented Feb 11, 2022

I have merged #142393 which adds the ability to create utils with a disposable store, Event.map(originalEvent, mapperFn, this._store). It's OK to always pass a store but when utils are used to create public event they shall do that. I have added a way to trace potential leakage through these utils and will create a follow-up issue

@jrieken jrieken closed this as completed Feb 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @jrieken @connor4312 and others