Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: has a tooltp with a keybinding #124335

Closed
bpasero opened this issue May 21, 2021 · 3 comments
Closed

Search: has a tooltp with a keybinding #124335

bpasero opened this issue May 21, 2021 · 3 comments
Assignees
@JacksonKearl
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders smoke-test-failure
Milestone
April 2022

Comments

@bpasero
Copy link
Member

bpasero commented May 21, 2021

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=119617&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=00d0ae10-f5a4-5438-a3b8-c58076933cab

1) VSCode Smoke Tests (Electron)
       VSCode Smoke Tests (Electron)
         Search
           has a tooltp with a keybinding:
     Error: Expected search tooltip to contain keybinding but got undefined
      at Context.<anonymous> (out/areas/search/search.test.js:21:23)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)
@meganrogge
Copy link
Contributor

@JacksonKearl have you gotten a chance to look into this?

@JacksonKearl
Copy link
Contributor

Yes, the test is now disabled.

@JacksonKearl JacksonKearl added this to the Backlog milestone Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
@bpasero
Copy link
Member Author

bpasero commented Apr 4, 2022 •
edited

I do not understand the course of action here? The issue is closed, yet the test is still there but disabled. Then remove it?

vscode/test/smoke/src/areas/search/search.test.ts

Lines 22 to 29 in bb39ae8

// https://github.com/microsoft/vscode/issues/124146
it.skip /* https://github.com/microsoft/vscode/issues/124335 */('has a tooltp with a keybinding', async function () {
const app = this.app as Application;
const tooltip: string = await app.workbench.search.getSearchTooltip();
if (!/Search \(.+\)/.test(tooltip)) {
throw Error(`Expected search tooltip to contain keybinding but got ${tooltip}`);
}
});

@bpasero bpasero reopened this Apr 4, 2022
@bpasero bpasero removed this from the Backlog milestone Apr 4, 2022
@JacksonKearl JacksonKearl added this to the April 2022 milestone Apr 4, 2022
@JacksonKearl JacksonKearl added the debt Code quality issues label Apr 4, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Fix microsoft#124335
16bf8d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders smoke-test-failure
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
4 participants
@bpasero @JacksonKearl @meganrogge and others