Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to rename registerContributionPoint #124762

Closed
bpasero opened this issue May 27, 2021 · 5 comments
Closed

Consider to rename registerContributionPoint #124762

bpasero opened this issue May 27, 2021 · 5 comments
Assignees
@lramos15
Labels
insiders-released Patch has been released in VS Code Insiders workbench-editor-resolver Issues resolving the editor inputs

Comments

@bpasero
Copy link
Member

bpasero commented May 27, 2021

I find the name registerContributionPoint a bit misleading because to me it sounds like I would register a new contribution point to the workbench that others can contribute to?

How about IEditorOverrideService#registerOverride?
@bpasero bpasero added the workbench-editor-resolver Issues resolving the editor inputs label May 27, 2021
@bpasero
Copy link
Member Author

bpasero commented May 27, 2021

Or to be future proof, IEditorOverrideService.registerEditor.

@lramos15
Copy link
Member

lramos15 commented Jun 7, 2021

I got rid of the idea of a contribution completely. Let me know if you like the new names

@bpasero
Copy link
Member Author

bpasero commented Jun 8, 2021

Yeah I like that. still a few "contributed..." things though:

image

@lramos15
Copy link
Member

lramos15 commented Jun 8, 2021

I kind of liked those ones but I can rename them as well to be Registered instead of Contributed

@bpasero
Copy link
Member Author

bpasero commented Jun 8, 2021

Yeah I like "registered" 👍

lramos15 added a commit that referenced this issue Jun 14, 2021
@lramos15
More #124762
8f1fb8a
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

Labels
insiders-released Patch has been released in VS Code Insiders workbench-editor-resolver Issues resolving the editor inputs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @lramos15 and others