Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trust editor: alternating background color for table widget? #125099

Closed
bpasero opened this issue Jun 1, 2021 · 8 comments
Closed

Trust editor: alternating background color for table widget? #125099

bpasero opened this issue Jun 1, 2021 · 8 comments
Assignees
@joaomoreno @lszomoru
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue table-widget verified Verification succeeded
Milestone
November 2021

Comments

@bpasero
Copy link
Member

bpasero commented Jun 1, 2021

Most of our tables chose to use alternating background colors, e.g. keybindings:

image

This somehow makes it easier for me to understand that I am looking at tabular data, wondering if we should do the same for trusted paths:

image
@bpasero
Copy link
Member Author

bpasero commented Jun 1, 2021

@alexr00 would this make sense for the ports view as well? Just realised ports also do not apply such a background color pattern:

image

Arguably this raises the question if such a pattern should be used for tables only, or lists in general which would probably look too noisy.

@bpasero
Copy link
Member Author

bpasero commented Jun 1, 2021

//cc @misolori

@alexr00
Copy link
Member

alexr00 commented Jun 1, 2021

@joaomoreno if we adopt this, maybe it should be for all table views.

@miguelsolorio
Copy link
Contributor

I like the update of using alternate bg colors 👍

@joaomoreno
Copy link
Member

joaomoreno commented Jun 2, 2021 •
edited

@alexr00 I thought we did this for the ports view as well?

We can just set the styles for every table at the workbench level.

@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 2, 2021
@joaomoreno joaomoreno self-assigned this Jun 2, 2021
@alexr00
Copy link
Member

alexr00 commented Jun 2, 2021

@joaomoreno I think I remember us looking at it and deciding not to have it. But I'm happy to go with the majority.

@lszomoru
Copy link
Member

I am happy to adopt this for the workspace trust editor.

@lszomoru lszomoru added feature-request Request for new features or functionality polish Cleanup and polish issue table-widget labels Oct 25, 2021
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach labels Nov 8, 2021
@joaomoreno joaomoreno added this to the November 2021 milestone Nov 8, 2021
@miguelsolorio
Copy link
Contributor

@joaomoreno 🙏 thanks for pulling in the colors from #135018

@bpasero bpasero added the verified Verification succeeded label Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@lszomoru lszomoru

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue table-widget verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
6 participants
@joaomoreno @bpasero @lszomoru @miguelsolorio @alexr00 and others