New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No link for disabled extensions on Workspace Trust screen #126614
Comments
(Experimental duplicate detection) |
@TylerLeonhardt, any insights on this? I thought that this has already been fixed. |
@lszomoru this is because in the translation they messed up the markdown syntax and added a space between the I suggest that you do the following that @JacksonKearl did here: and have the markdown syntax be included in the interpolated bit and not be passed to the translators. |
@TylerLeonhardt I don't know if its actually safe to do that. The markdown bit is actually part of the phrase here and some languages might need to reorder the text. This is why I haven't done it this way currently. |
Good point. Can you at least include a comment to tell the translators to honor the |
@sbatten I can't imagine translating I don't think it's safe to expect the translators to know and persist MD syntax, and while the comments help it still feels risky (the above comment makes no mention of anything special besides |
well, it's a count and plural noun, and as someone who is not an expert on linguistics of the world, I didn't want to assume that its safe. specifically, because a broken translation with markdown syntax is a fairly easy one-time fix, whereas the alternative potentially limits the end result. I am happy to change it if this is not a concern |
On one had you have a broken experience if translators make a mistake in MD syntax (even with comment fields there's room for human error), on the other the translated string might be awkward but the experience is more-or-less guaranteed to work. 🤷♀️ One more consideration is that we don't actually classify the holes at all. Translators would have no idea if the hole is a count or an adjective or an interjection or what. |
I'll leave it up to you @sbatten & @lszomoru but I think your options are:
I'm kinda in favor of the 2nd option... personally but don't care which route you take. |
I ended up encountering a similar structured string elsewhere in the same file. In that case, using the second approach would have resulted in a translator having 3 strings to translate without context that they would be concatenated. For that reason and consistency, I've opted for a comment. |
We may have to wait for the next release of this language pack (next Tuesday) |
Verification needs the latest language pack... Closing this item to keep it off the endgame query for open issues. |
@sbatten @lszomoru until I have time to actually work on the |
@v-mholloway where are we going wrong here on the translation side? There's clearly a comment in Resource Fabric: Please inform the translators that they absolutely need to read the comments otherwise they will break the product. |
@TylerLeonhardt it is the same place as describe here: microsoft/vscode-loader#31 |
I did a basic implementation for the workspace trust translations where I remove the whitespace in the middle of a markdown link. I did this in favor of introducing yet more localized strings and changing them again for all translations. |
@cristianosuzuki77, for information, need to seek the way to enforce no space added in translation for markdown link between [Link text] and (Link). |
Ok since we have @sbatten's implementation and microsoft/vscode-loader#31 let's go ahead and close this. @danyeh I'm curious to know what is being done to ensure there is no space added between the [Link text] and (Link) on your end for our own context. |
verification steps:
Ensure buttons are correctly rendered. |
@TylerLeonhardt , add a dev comment like {Locked="]({1})"} should be able to enforce there is no space added between.
|
@danyeh just to clarify... when you say "dev comment" you mean like the comments that show up here? so if I add a comment that says |
@TylerLeonhardt , yes, what you mentioned is correct. |
Verified in |
Issue Type: Bug
Extension links do not appear in the restricted mode screen of the Workspace Trust.
VS Code version: Code 1.57.0 (b4c1bd0, 2021-06-09T17:22:31.215Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No
System Info
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (71)
(5 theme extensions excluded)
A/B Experiments
The text was updated successfully, but these errors were encountered: