Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When multiple ghost text parts have line breaks, the first line of the ghost text gets deleted #128302

Closed
hediet opened this issue Jul 9, 2021 · 1 comment · Fixed by #128303 or #128624
Closed

When multiple ghost text parts have line breaks, the first line of the ghost text gets deleted #128302

hediet opened this issue Jul 9, 2021 · 1 comment · Fixed by #128303 or #128624
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
June 2021 Recovery 2

Comments

@hediet
Copy link
Member

hediet commented Jul 9, 2021 •
edited

image

It should look like this:
image

Copilot currently does not trigger this behavior, as they currently don't suggest multi line text in the middle of lines, thus I guess this bug is not very critical.

Steps to verify:
Enable "editor.suggest.preview": true, and set "editor.suggest.previewMode": "subword",.
Then type "quick" in the settings editor and ensure that the cursor is at "quick|" (see screenshot). Notice the ghost text that previews the text buffer as if the suggestion was accepted, as in the reference screenshot.
(In the reference screenshot, "editor.quick" has been typed, but that does not affect the outcome.)
@hediet hediet added this to the July 2021 milestone Jul 9, 2021
@hediet hediet self-assigned this Jul 9, 2021
hediet added a commit that referenced this issue Jul 9, 2021
@hediet
Fixes #128302.
a6f056e
@hediet hediet added candidate Issue identified as probable candidate for fixing in the next release bug Issue identified by VS Code Team member as probable bug labels Jul 9, 2021
@hediet hediet linked a pull request Jul 9, 2021 that will close this issue
Fixes #128302. #128303
Merged
hediet added a commit that referenced this issue Jul 9, 2021
@hediet
Merge pull request #128303 from microsoft/hediet/fix-128302
a98d40d 
Fixes #128302.
@hediet hediet reopened this Jul 9, 2021
@hediet hediet modified the milestones: July 2021, June 2021 Recovery Jul 9, 2021
hediet added a commit that referenced this issue Jul 14, 2021
@hediet
Fixes #128302.
065c301
@hediet hediet mentioned this issue Jul 14, 2021
Merged
@hediet hediet linked a pull request Jul 14, 2021 that will close this issue
Don't modify ghost text when reading it #128624
Merged
@chrmarti
Copy link
Contributor

Verified with "subwordDiff" (there is no "subword" in 1.58):
image

@chrmarti chrmarti added the verified Verification succeeded label Jul 15, 2021
@hediet hediet closed this as completed Jul 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
June 2021 Recovery 2
Development

Successfully merging a pull request may close this issue.

Fixes #128302. microsoft/vscode
Don't modify ghost text when reading it microsoft/vscode
3 participants
@hediet @alexdima @chrmarti