Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings UI] No warning for object with "additionalProperties": false #128429

Closed
usernamehw opened this issue Jul 11, 2021 · 1 comment · Fixed by #129066
Closed

[Settings UI] No warning for object with "additionalProperties": false #128429

usernamehw opened this issue Jul 11, 2021 · 1 comment · Fixed by #129066
Assignees
@roblourens @rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
July 2021

Comments

@usernamehw
Copy link
Contributor

Have an object type for extension settings:

"todomd.suggestItems": {
    "type": "object",
    "patternProperties": {
        "^#": {
            "type": "string",
            "description": "IT IS YOUR TAG."
        }
    },
    "additionalProperties": false,
    "default": {}
},
"todomd.suggestItems": {
	"#asdf": "",
	"asdf": "",
},
settings.json Settings UI
Screenshot (114) Screenshot (113)
@vscodebot
Copy link

vscodebot bot commented Jul 11, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jul 14, 2021
@rzhao271 rzhao271 added this to the July 2021 milestone Jul 20, 2021
@rzhao271 rzhao271 mentioned this issue Jul 20, 2021
Closed
rzhao271 added a commit that referenced this issue Jul 20, 2021
@rzhao271
Add validation for objects, fixes #128429
2d400c8
This was referenced Jul 20, 2021
Merged
Closed
rzhao271 added a commit that referenced this issue Jul 21, 2021
@rzhao271
Add validation for objects, fixes #128429
c904b80
rzhao271 added a commit that referenced this issue Jul 22, 2021
@rzhao271
Add validation for objects, fixes #128429
38c2756
rzhao271 added a commit that referenced this issue Jul 23, 2021
@rzhao271
Add validation for objects, fixes #128429 (#129066)
ae29089 
* Add validation for objects, fixes #128429
@rzhao271 rzhao271 mentioned this issue Jul 26, 2021
Closed
3 tasks
rzhao271 added a commit that referenced this issue Jul 26, 2021
@rzhao271
Add validation for boolean values, affects #128429
56d3a7d
@JacksonKearl JacksonKearl added the verified Verification succeeded label Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Add validation for objects, fixes #128429 microsoft/vscode
5 participants
@roblourens @rzhao271 @JacksonKearl @usernamehw and others