Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test explorer shows nothing if Show in Active File Only is enabled #129476

Closed
jdneo opened this issue Jul 27, 2021 · 2 comments
Closed

Test explorer shows nothing if Show in Active File Only is enabled #129476

jdneo opened this issue Jul 27, 2021 · 2 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
August 2021

Comments

@jdneo
Copy link
Member

jdneo commented Jul 27, 2021

Version: 1.59.0-insider (user setup)
Commit: 955a1ac
Date: 2021-07-26T05:13:58.801Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19043

  1. Use this the extension sample: test-provider-sample with this change applied jdneo/vscode-extension-samples@d0e96ee
  2. Here .md files nested in a folder, and when Show in Active File Only, they disappeared in the test explorer

@connor4312
@vscodebot
Copy link

vscodebot bot commented Jul 27, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jdneo jdneo mentioned this issue Jul 27, 2021
Closed
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jul 27, 2021
@connor4312 connor4312 added this to the August 2021 milestone Jul 27, 2021
@jdneo
Copy link
Member Author

jdneo commented Aug 2, 2021

Hi @connor4312,

The original issue was fixed in 24ae09b,

While I was playing with the newest insider, I found (maybe) another problem regarding this Show in Active File Only feature.

You can try to add more nested folders, like this: microsoft/vscode-extension-samples@main...jdneo:cs/128824

128824.mp4

Ideally, the folder test should not appear in the test explorer, since it's not containing any test items whose uri equals to the active document.

@sandy081 sandy081 added the verified Verification succeeded label Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
4 participants
@connor4312 @jdneo @sandy081 and others